From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <git-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN: AS31976 209.132.180.0/23
X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RP_MATCHES_RCVD
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by dcvr.yhbt.net (Postfix) with ESMTP id 74B5420193
	for <e@80x24.org>; Thu, 11 Aug 2016 19:30:43 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752625AbcHKTaX (ORCPT <rfc822;e@80x24.org>);
	Thu, 11 Aug 2016 15:30:23 -0400
Received: from pb-smtp1.pobox.com ([64.147.108.70]:63316 "EHLO
	sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752569AbcHKTaV (ORCPT <rfc822;git@vger.kernel.org>);
	Thu, 11 Aug 2016 15:30:21 -0400
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1])
	by pb-smtp1.pobox.com (Postfix) with ESMTP id A28A131111;
	Thu, 11 Aug 2016 15:30:19 -0400 (EDT)
DKIM-Signature:	v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type; s=sasl; bh=8l0d8K0BnZ09vBbAiZz2WlXSPxA=; b=FaD4Eg
	5hfZzc+5UnmFOxInPR5bIOc/qznzyZHuggWQcP/r25kSwbyrTn+jHQweNCLMXDcM
	QJaklV5hxYAxf5SPii+YO8KKV2syG3levuxcsz8/OORG4G8zOpAKlG5KM2jq1G8h
	AcVfhF9bnaw6SHDbsjqZmHmyRrc5NPRNPjjj0=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc
	:subject:references:date:in-reply-to:message-id:mime-version
	:content-type; q=dns; s=sasl; b=uZ3QCLl7ahdfDIva3fAL31xUt2gUBhix
	s89MFgbgrMTaLcYlAtdL6VBn5WBN/FqXgy8CVHkdxAhd1FWw2oTIjiFakyx2puxH
	JEBgpdkWJFemDsPLl43GFBV0NXZyq3p3nRcfiFmy6cspm987KGDzQnsISH/iUDuT
	ydq3aDoOvrI=
Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1])
	by pb-smtp1.pobox.com (Postfix) with ESMTP id 959D031110;
	Thu, 11 Aug 2016 15:30:19 -0400 (EDT)
Received: from pobox.com (unknown [104.132.0.95])
	(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 013763110F;
	Thu, 11 Aug 2016 15:30:19 -0400 (EDT)
From:	Junio C Hamano <gitster@pobox.com>
To:	Christian Couder <christian.couder@gmail.com>
Cc:	git <git@vger.kernel.org>, Jeff King <peff@peff.net>,
	=?utf-8?B?w4Z2?= =?utf-8?B?YXIgQXJuZmrDtnLDsA==?= 
	<avarab@gmail.com>, Karsten Blees <karsten.blees@gmail.com>,
	Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
	Stefan Beller <sbeller@google.com>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Johannes Sixt <j6t@kdbg.org>,
	=?utf-8?Q?Ren=C3=A9?= Scharfe <l.s.r@web.de>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v10 33/40] environment: add set_index_file()
References: <20160808210337.5038-1-chriscool@tuxfamily.org>
	<20160808210337.5038-34-chriscool@tuxfamily.org>
	<xmqq60raewod.fsf@gitster.mtv.corp.google.com>
	<CAP8UFD2ZAdUjQnO-4qnum2_AK84SfBN2_yO=py+Jj+pkV8pk-w@mail.gmail.com>
	<xmqqlh045y0l.fsf@gitster.mtv.corp.google.com>
	<CAP8UFD3-0=O7uLXG=KL8OVueFPCpN5y-JmtcncVyrd8GoRh--g@mail.gmail.com>
Date:	Thu, 11 Aug 2016 12:30:17 -0700
In-Reply-To: <CAP8UFD3-0=O7uLXG=KL8OVueFPCpN5y-JmtcncVyrd8GoRh--g@mail.gmail.com>
	(Christian Couder's message of "Thu, 11 Aug 2016 21:08:50 +0200")
Message-ID: <xmqqeg5v14ty.fsf@gitster.mtv.corp.google.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Pobox-Relay-ID: 09B6E9D2-5FFA-11E6-8756-89D312518317-77302942!pb-smtp1.pobox.com
Sender:	git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List:	git@vger.kernel.org

Christian Couder <christian.couder@gmail.com> writes:

> Yeah, it is feasible and perhaps even simpler using
> hold_lock_file_for_update() than with set_index_file(), so I
> dropped the set_index_file() patch and added a new one that uses
> hold_lock_file_for_update().

I wasn't paying too close an attention while reading the changes,
but anyway that is a great news.

Thanks.