git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Vinicius Kursancew <viniciusalexandre@gmail.com>,
	Luke Diamand <luke@diamand.org>,
	Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] allow git-p4 to create shelved changelists
Date: Mon, 28 Nov 2016 11:06:05 -0800	[thread overview]
Message-ID: <xmqqeg1vjug2.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1480325598-12344-1-git-send-email-viniciusalexandre@gmail.com> (Vinicius Kursancew's message of "Mon, 28 Nov 2016 09:33:17 +0000")

Vinicius Kursancew <viniciusalexandre@gmail.com> writes:

> This patch adds a "--shelve" option to the submit subcommand, it will
> save the changes to a perforce shelve instead of commiting them.
>
> Vinicius Kursancew (1):
>   git-p4: allow submit to create shelved changelists.
>
>  Documentation/git-p4.txt |  5 +++++
>  git-p4.py                | 36 ++++++++++++++++++++++--------------
>  t/t9807-git-p4-submit.sh | 31 +++++++++++++++++++++++++++++++
>  3 files changed, 58 insertions(+), 14 deletions(-)

Thanks, but I am a wrong person to review this change, so I'll
summon two people who appear in "git shortlog --since=18.months"
output to help review it.



  parent reply	other threads:[~2016-11-28 19:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28  9:33 [PATCH] allow git-p4 to create shelved changelists Vinicius Kursancew
2016-11-28  9:33 ` [PATCH] git-p4: allow submit " Vinicius Kursancew
2016-11-28 19:06 ` Junio C Hamano [this message]
2016-11-29 12:47   ` [PATCH] allow git-p4 " Luke Diamand
2016-11-29 18:59     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeg1vjug2.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=luke@diamand.org \
    --cc=viniciusalexandre@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).