From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Mar 2017, #01; Wed, 1)
Date: Wed, 01 Mar 2017 15:08:10 -0800 [thread overview]
Message-ID: <xmqqefygegth.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <52f043cc-7b39-5ab7-bcdc-894aeb402c12@web.de> ("René Scharfe"'s message of "Wed, 1 Mar 2017 23:57:52 +0100")
René Scharfe <l.s.r@web.de> writes:
> Am 01.03.2017 um 23:35 schrieb Junio C Hamano:
>> * rs/log-email-subject (2017-03-01) 2 commits
>> - pretty: use fmt_output_email_subject()
>> - log-tree: factor out fmt_output_email_subject()
>>
>> Code clean-up.
>>
>> Will merge to 'next'.
>
> Could you please squash this in? We only use a single context (as
> opposed to an array), so it doesn't have to be especially compact,
> and using a bitfield slows down half of the tests in p4000 by 3%
> for me.
I thought I saw the keyword "bitfield" to the solution for that 3%
somewhere in the thread and forgot when I updated the "What's
cooking" report.
Will do. Thanks for being careful.
>
> ---
> commit.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commit.h b/commit.h
> index 459daef94a..528272ac9b 100644
> --- a/commit.h
> +++ b/commit.h
> @@ -154,7 +154,7 @@ struct pretty_print_context {
> int preserve_subject;
> struct date_mode date_mode;
> unsigned date_mode_explicit:1;
> - unsigned print_email_subject:1;
> + int print_email_subject;
> int expand_tabs_in_log;
> int need_8bit_cte;
> char *notes_message;
prev parent reply other threads:[~2017-03-01 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 22:35 What's cooking in git.git (Mar 2017, #01; Wed, 1) Junio C Hamano
2017-03-01 22:57 ` René Scharfe
2017-03-01 23:08 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefygegth.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).