From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Christian Couder" <christian.couder@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"David Turner" <dturner@twopensource.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Torsten Bögershausen" <tboegi@web.de>,
"Stefan Beller" <sbeller@google.com>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH v8 04/11] update-index: add untracked cache notifications
Date: Thu, 30 Mar 2017 10:33:16 -0700 [thread overview]
Message-ID: <xmqqefxe655v.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170330032858.rdklpoipmvwjov4d@sigill.intra.peff.net> (Jeff King's message of "Wed, 29 Mar 2017 23:28:58 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Jan 27, 2016 at 07:58:00AM +0100, Christian Couder wrote:
>
>> diff --git a/builtin/update-index.c b/builtin/update-index.c
>> index 62222dd..369c207 100644
>> --- a/builtin/update-index.c
>> +++ b/builtin/update-index.c
>> @@ -130,7 +130,7 @@ static int test_if_untracked_cache_is_supported(void)
>> if (!mkdtemp(mtime_dir.buf))
>> die_errno("Could not make temporary directory");
>>
>> - fprintf(stderr, _("Testing "));
>> + fprintf(stderr, _("Testing mtime in '%s' "), xgetcwd());
>
> Coverity points out that this is a leak (xgetcwd returns an allocated
> buffer).
I saw that quite recently and was wondering why it reported it this
late. It has been in 'master' for more than a month.
In any case, thanks for noticing and I agree the fix in the other
message is obviously correct.
next prev parent reply other threads:[~2017-03-30 17:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 6:57 [PATCH v8 00/11] Untracked cache improvements Christian Couder
2016-01-27 6:57 ` [PATCH v8 01/11] dir: free untracked cache when removing it Christian Couder
2016-01-27 6:57 ` [PATCH v8 02/11] update-index: use enum for untracked cache options Christian Couder
2016-01-27 6:57 ` [PATCH v8 03/11] update-index: add --test-untracked-cache Christian Couder
2016-01-27 6:58 ` [PATCH v8 04/11] update-index: add untracked cache notifications Christian Couder
2017-03-30 3:28 ` Jeff King
2017-03-30 6:24 ` Christian Couder
2017-03-30 17:33 ` Junio C Hamano [this message]
2017-03-30 17:47 ` Stefan Beller
2016-01-27 6:58 ` [PATCH v8 05/11] update-index: move 'uc' var declaration Christian Couder
2016-01-27 6:58 ` [PATCH v8 06/11] dir: add {new,add}_untracked_cache() Christian Couder
2016-01-27 6:58 ` [PATCH v8 07/11] dir: add remove_untracked_cache() Christian Couder
2016-01-27 6:58 ` [PATCH v8 08/11] dir: simplify untracked cache "ident" field Christian Couder
2016-01-27 6:58 ` [PATCH v8 09/11] config: add core.untrackedCache Christian Couder
2016-01-27 6:58 ` [PATCH v8 10/11] test-dump-untracked-cache: don't modify the untracked cache Christian Couder
2016-01-27 6:58 ` [PATCH v8 11/11] t7063: add tests for core.untrackedCache Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefxe655v.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=sunshine@sunshineco.com \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).