From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Ben Peart <peartben@gmail.com>,
xiaoqiang zhao <zxq_yx_007@163.com>
Subject: Re: What's cooking in git.git (Jun 2017, #06; Thu, 22)
Date: Fri, 23 Jun 2017 17:27:30 -0700 [thread overview]
Message-ID: <xmqqefuab571.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqo9tfff2w.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Thu, 22 Jun 2017 22:28:07 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>>> * ab/sha1dc (2017-06-07) 2 commits
>>> ...
>>> Will keep in 'pu'.
>>> Impact to the various build and release infrastructure of using
>>> submodule is not yet fully known, but this lets us dip our toes.
>> ...
>> But it's been 1 month kicking around in pu now. What are we gaining from
>> keeping it there even longer at this point?
>
> I am sort of waiting for a success from Windows box at Travis. It
> hasn't passed for other reasons for a while, though.
https://travis-ci.org/git/git/jobs/246371006#L480 shows that on
Linux, we are taking the code from the submodule and the compilation
is happy.
https://travis-ci.org/git/git/jobs/246371008#L25 shows that we do
init and update the submodule but it does not appear that neither
the bundled sha1dc/ nor the submodule gets used on MacOS. Probably
we are using the hash from the platform?
https://travis-ci.org/git/git/jobs/246371011#L724 shows that the
bundled sha1dc/ is used on Windows, not from the submodule, for
whatever reason. I trust what Dscho does for Windows platform well
enough that I do not feel unconfortable for not knowing why the
build there triggered by Travis does not use the submodule one.
Whatever configuration he chooses would be the best for the
platform.
So the only nit I may have is that we may possibly want to turn this
on in .travis.yml on MacOS before we move it forward (otherwise we'd
be shipping bundled one and submodule one without doing any build on
that platform)? Other than that, the topic seems ready to be merged
down.
Thanks.
next prev parent reply other threads:[~2017-06-24 0:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 22:35 What's cooking in git.git (Jun 2017, #06; Thu, 22) Junio C Hamano
2017-06-22 22:58 ` Ævar Arnfjörð Bjarmason
2017-06-23 5:28 ` Junio C Hamano
2017-06-24 0:27 ` Junio C Hamano [this message]
2017-06-23 9:43 ` Lars Schneider
2017-06-23 21:59 ` Ævar Arnfjörð Bjarmason
2017-06-23 23:39 ` Stefan Beller
2017-06-24 0:37 ` Junio C Hamano
2017-06-24 1:01 ` Junio C Hamano
2017-06-27 2:58 ` Stefan Beller
2017-06-24 0:16 ` Stefan Beller
2017-06-24 0:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefuab571.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peartben@gmail.com \
--cc=zxq_yx_007@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).