From: Junio C Hamano <gitster@pobox.com>
To: Charles Bailey <charles@hashpling.org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Fix NO_LIBPCRE1_JIT to fully disable JIT
Date: Tue, 14 Nov 2017 11:12:03 +0900 [thread overview]
Message-ID: <xmqqefp17gng.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171113065410.rb43utcbncy7ndrv@hashpling.org> (Charles Bailey's message of "Mon, 13 Nov 2017 06:54:10 +0000")
Charles Bailey <charles@hashpling.org> writes:
>> > But that we should take it anyway regardless of that since it'll *also*
>> > work on Linux with your patch, and this logic makes some sense whereas
>> > the other one clearly didn't and just worked by pure accident of some
>> > toolchain semantics that I haven't figured out yet.
>>
>> That is curious and would be nice to know the answer to.
>
> The error that I was getting ...
> My guess is that we are just exposing a pre-existing bug in our Solaris
> build of libpcre.
Sorry, my question was not clear. I think you already mentioned the
above in the thread. What I was curious about was why Ævar was
seeing that JIT disabled with NO_LIBPCRE1_JIT alone on his Linux
setup, i.e. namely this part from his message:
*But* for some reason you still get away with that on Linux. I
don't know why, but I assume the compiler toolchain is more lax
for some reason than on Solaris.n
In any case, thanks for a fix; queued.
prev parent reply other threads:[~2017-11-14 2:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 16:59 [PATCH] Fix NO_LIBPCRE1_JIT to fully disable JIT Charles Bailey
2017-11-12 20:47 ` Ævar Arnfjörð Bjarmason
2017-11-13 3:53 ` Junio C Hamano
2017-11-13 6:54 ` Charles Bailey
2017-11-14 2:12 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefp17gng.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).