From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 0/2] diff: add --stat-with-summary (was --compact-summary)
Date: Fri, 02 Feb 2018 11:59:32 -0800 [thread overview]
Message-ID: <xmqqefm3cgd7.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180201130221.15563-1-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Thu, 1 Feb 2018 20:02:19 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> Changes since v2 [1]:
>
> - goes back to my original version (yay!) where the extra info
> is appended after the path name. More is described in 2/2
> - --compact-summary is now renamed --stat-with-summary and implies
> --stat
> - 1/2 is just a cleanup patch to make it easier to add 2/2
It may be just me and other old timers, but --X-with-Y naming means
quite different thing around these commands, and --stat-with-summary
would hint, at least to us, that it would behave as if the two
options "--stat --summary" are given at the same time.
And from that point of view, the new name is a bit confusing one.
The patches themselves look excellent. Thanks.
next prev parent reply other threads:[~2018-02-02 19:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 13:02 [PATCH v3 0/2] diff: add --stat-with-summary (was --compact-summary) Nguyễn Thái Ngọc Duy
2018-02-01 13:02 ` [PATCH v3 1/2] diff.c: refactor pprint_rename() to use strbuf Nguyễn Thái Ngọc Duy
2018-02-01 13:02 ` [PATCH v3 2/2] diff: add --stat-with-summary Nguyễn Thái Ngọc Duy
2018-02-02 19:59 ` Junio C Hamano [this message]
2018-02-05 11:28 ` [PATCH v3 0/2] diff: add --stat-with-summary (was --compact-summary) Duy Nguyen
2018-02-05 18:56 ` Junio C Hamano
2018-02-06 10:20 ` Duy Nguyen
2018-02-07 9:52 ` Eric Sunshine
2018-02-07 10:36 ` Duy Nguyen
2018-02-07 18:19 ` Junio C Hamano
2018-02-10 10:24 ` Duy Nguyen
2018-02-10 20:08 ` Junio C Hamano
2018-02-24 14:05 ` [PATCH v4 0/2] diff: add --compact-summary (aka nd/diff-stat-with-summary) Nguyễn Thái Ngọc Duy
2018-02-24 14:05 ` [PATCH v4 1/2] diff.c: refactor pprint_rename() to use strbuf Nguyễn Thái Ngọc Duy
2018-02-24 14:05 ` [PATCH v4 2/2] diff: add --stat-with-summary Nguyễn Thái Ngọc Duy
2018-02-24 14:09 ` [PATCH v5 0/2] diff: add --compact-summary (aka nd/diff-stat-with-summary) Nguyễn Thái Ngọc Duy
2018-02-24 14:09 ` [PATCH v5 1/2] diff.c: refactor pprint_rename() to use strbuf Nguyễn Thái Ngọc Duy
2018-02-24 14:09 ` [PATCH v5 2/2] diff: add --compact-summary Nguyễn Thái Ngọc Duy
2018-02-27 23:24 ` [PATCH v5 0/2] diff: add --compact-summary (aka nd/diff-stat-with-summary) Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefm3cgd7.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).