From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] docs/interpret-trailers: fix agreement error
Date: Thu, 08 Feb 2018 12:29:53 -0800 [thread overview]
Message-ID: <xmqqeflvql6m.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180208101358.af4ecca9865dca4f04431bce@google.com> (Jonathan Tan's message of "Thu, 8 Feb 2018 10:13:58 -0800")
Jonathan Tan <jonathantanmy@google.com> writes:
> On Thu, 8 Feb 2018 02:56:14 +0000
> "brian m. carlson" <sandals@crustytoothpaste.net> wrote:
>
>> Existing trailers are extracted from the input message by looking for
>> -a group of one or more lines that (i) are all trailers, or (ii) contains at
>> -least one Git-generated or user-configured trailer and consists of at
>> +a group of one or more lines that (i) are all trailers, or (ii) contain at
>> +least one Git-generated or user-configured trailer and consist of at
>> least 25% trailers.
>> The group must be preceded by one or more empty (or whitespace-only) lines.
>> The group must either be at the end of the message or be the last
>
> Ah, good catch. Maybe "a group of one or more lines that (i) consists of all
> trailers, or (ii) contains ..."?
Your version reads better perhaps because it talks about "a group"
without placing undue stress on the fact that the member of the
group are usually multiple---I guess it is better over Brian's?
next prev parent reply other threads:[~2018-02-08 20:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 2:56 [PATCH] docs/interpret-trailers: fix agreement error brian m. carlson
2018-02-08 18:13 ` Jonathan Tan
2018-02-08 20:29 ` Junio C Hamano [this message]
2018-02-10 16:57 ` brian m. carlson
2018-02-13 2:23 ` [PATCH v2] " brian m. carlson
2018-02-13 18:41 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeflvql6m.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).