From: Junio C Hamano <gitster@pobox.com>
To: Leah Neukirchen <leah@vuxu.org>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH] color: respect the $NO_COLOR convention
Date: Thu, 01 Mar 2018 09:10:58 -0800 [thread overview]
Message-ID: <xmqqefl3iuvx.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <87zi3reoez.fsf@gmail.com> (Leah Neukirchen's message of "Thu, 01 Mar 2018 17:44:20 +0100")
Leah Neukirchen <leah@vuxu.org> writes:
> NO_COLOR (http://no-color.org/) is a comprehensive approach to disable
> colors by default for all tools:
The list of software that supports that "convention" is, eh,
respectable. Is it really a "convention" yet, or yet another thing
the user needs to worry about?
> diff --git a/color.c b/color.c
> index d48dd947c..59e9c2459 100644
> --- a/color.c
> +++ b/color.c
> @@ -326,6 +326,8 @@ int git_config_colorbool(const char *var, const char *value)
>
> static int check_auto_color(void)
> {
> + if (getenv("NO_COLOR"))
> + return 0;
Our convention often calls for CONFIG_VAR=false to mean "I do not
want to see what CONFIG_VAR wants to do done", i.e.
NO_COLOR=false git show
would show colored output if there is no other settings. But this
code contradicts the convention, deliberately because that is what
no-color.org wants. Makes me wonder if that convention is worth
following in the first place.
> if (color_stdout_is_tty < 0)
> color_stdout_is_tty = isatty(1);
> if (color_stdout_is_tty || (pager_in_use() && pager_use_color)) {
According to no-color.org's FAQ #2, NO_COLOR should affect only the
"default" behaviour, and should stay back if there is an explicit
end-user configuration (or command line override). And this helper
function is called only from want_color() when their is no such
higher precedence setting, which is in line with the recommendation.
Which is good.
next prev parent reply other threads:[~2018-03-01 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 16:44 [RFC PATCH] color: respect the $NO_COLOR convention Leah Neukirchen
2018-03-01 17:10 ` Junio C Hamano [this message]
2018-03-01 17:23 ` Leah Neukirchen
2018-03-01 19:06 ` Junio C Hamano
2018-03-04 22:39 ` brian m. carlson
2018-03-05 2:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqefl3iuvx.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=leah@vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).