git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, "Łukasz Stelmach" <l.stelmach@samsung.com>
Subject: Re: [PATCH] completion: complete remote names too
Date: Wed, 30 May 2018 12:49:55 +0900	[thread overview]
Message-ID: <xmqqefhtera4.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180525104842.2930-1-l.stelmach@samsung.com> ("Łukasz Stelmach"'s message of "Fri, 25 May 2018 12:48:42 +0200")

Łukasz Stelmach <l.stelmach@samsung.com> writes:

> "git remote update" accepts both groups and single remotes.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Soliciting comments from usual suspects around this area...

Thanks.

> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 961a0ed76..fb05bb2f9 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2632,7 +2632,7 @@ _git_remote ()
>  		__gitcomp_builtin remote_update
>  		;;
>  	update,*)
> -		__gitcomp "$(__git_get_config_variables "remotes")"
> +		__gitcomp "$(__git_remotes) $(__git_get_config_variables "remotes")"
>  		;;
>  	set-url,--*)
>  		__gitcomp_builtin remote_set-url

  reply	other threads:[~2018-05-30  3:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180525104848eucas1p28c88d657362066ea26d4eedaaef71f90@eucas1p2.samsung.com>
2018-05-25 10:48 ` [PATCH] completion: complete remote names too Łukasz Stelmach
2018-05-30  3:49   ` Junio C Hamano [this message]
2018-05-30 15:37   ` Duy Nguyen
     [not found]     ` <CGME20180604082049eucas1p1a81cdb5ae39a76d4421ccdbce4dcdbba@eucas1p1.samsung.com>
2018-06-04  8:20       ` Łukasz Stelmach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqefhtera4.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=l.stelmach@samsung.com \
    --cc=pclouds@gmail.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).