From: Junio C Hamano <gitster@pobox.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: git@vger.kernel.org, debian@onerussian.com
Subject: Re: [PATCH v2 4/4] dir: do not traverse repositories with no commits
Date: Wed, 03 Apr 2019 17:05:12 +0900 [thread overview]
Message-ID: <xmqqef6jsedj.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190402183505.31512-5-kyle@kyleam.com> (Kyle Meyer's message of "Tue, 2 Apr 2019 14:35:05 -0400")
Kyle Meyer <kyle@kyleam.com> writes:
> The above case is a corner case in an already unusual situation of the
> working tree containing a repository that is not a tracked submodule,
> but we might as well treat anything that looks like a repository
> consistently.
Makes sense.
> As the required update to t3700-add shows, being looser with the check
> means that we're stricter when adding empty repositories to the index:
>
> % git add repo
> warning: adding embedded git repository: repo
> hint: You've added another git repository inside your current repository.
> hint: [...]
> error: unable to index file 'repo/'
> fatal: adding files failed
Hmph, why should we have the initial "warning" with hint? Shouldn't
the above result in an outright error? Something like:
$ git add repo ;# or git add repo/
error: repo does not have a commit checked out
fatal: adding files failed
because the entire purpose of "git add repo" (or "git add repo/") when
"repo" is a repository is to register the commit that is checked out
in that sub-repository to the index of the top-level repository, as
part of updating (or starting) a submodule.
I very much like the direction these four patches want to take us.
I just have small troubles here and there in their execution, though
;-)
Thanks.
next prev parent reply other threads:[~2019-04-03 8:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 15:02 [PATCH 0/4] dir: Treat a repository without commits as a repository Kyle Meyer
2019-03-14 15:02 ` [PATCH 1/4] submodule: refuse to add repository with no commits Kyle Meyer
2019-03-16 15:40 ` Kyle Meyer
2019-04-02 18:35 ` [PATCH v2 0/4] dir: Treat a repository without commits as a repository Kyle Meyer
2019-04-02 18:35 ` [PATCH v2 1/4] submodule: refuse to add repository with no commits Kyle Meyer
2019-04-04 7:24 ` Junio C Hamano
2019-04-02 18:35 ` [PATCH v2 2/4] t3000: move non-submodule repo test to separate file Kyle Meyer
2019-04-03 7:59 ` Junio C Hamano
2019-04-03 22:21 ` Kyle Meyer
2019-04-02 18:35 ` [PATCH v2 3/4] t3009: test that ls-files -o traverses bogus repo Kyle Meyer
2019-04-02 18:35 ` [PATCH v2 4/4] dir: do not traverse repositories with no commits Kyle Meyer
2019-04-03 8:05 ` Junio C Hamano [this message]
2019-04-03 22:25 ` Kyle Meyer
2019-03-14 15:02 ` [PATCH 2/4] t3000: move non-submodule repo test to separate file Kyle Meyer
2019-03-14 15:02 ` [PATCH 3/4] t3009: test that ls-files -o traverses bogus repo Kyle Meyer
2019-03-14 15:02 ` [PATCH 4/4] dir: do not traverse repositories with no commits Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqef6jsedj.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=debian@onerussian.com \
--cc=git@vger.kernel.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).