* [PATCH] kset.h, tar.h: add missing header guard to prevent multiple inclusion
@ 2019-11-07 10:12 Elia Pinto
2019-11-07 11:11 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Elia Pinto @ 2019-11-07 10:12 UTC (permalink / raw)
To: git; +Cc: Elia Pinto
Add missing headers to prevent ill-effects from multiple inclusion.
Found by the LGTM source code analyzer.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
kwset.h | 4 ++++
tar.h | 5 +++++
2 files changed, 9 insertions(+)
diff --git a/kwset.h b/kwset.h
index df99a92178..f50ecae573 100644
--- a/kwset.h
+++ b/kwset.h
@@ -1,3 +1,6 @@
+#ifndef KWSET_H
+#define KWSET_H
+
/* This file has been copied from commit e7ac713d^ in the GNU grep git
* repository. A few small changes have been made to adapt the code to
* Git.
@@ -59,3 +62,4 @@ size_t kwsexec(kwset_t, char const *, size_t, struct kwsmatch *);
/* Deallocate the given keyword set and all its associated storage. */
void kwsfree(kwset_t);
+#endif /* KWSET_H */
diff --git a/tar.h b/tar.h
index 3467705e9b..6b258c4d4a 100644
--- a/tar.h
+++ b/tar.h
@@ -1,3 +1,6 @@
+#ifndef TAR_H
+#define TAR_H
+
#define TYPEFLAG_AUTO '\0'
#define TYPEFLAG_REG '0'
#define TYPEFLAG_LNK '2'
@@ -23,3 +26,5 @@ struct ustar_header {
char devminor[8]; /* 337 */
char prefix[155]; /* 345 */
};
+
+#endif /* TAR_H */
--
2.24.0.rc0.467.g566ccdd3e4.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kset.h, tar.h: add missing header guard to prevent multiple inclusion
2019-11-07 10:12 [PATCH] kset.h, tar.h: add missing header guard to prevent multiple inclusion Elia Pinto
@ 2019-11-07 11:11 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2019-11-07 11:11 UTC (permalink / raw)
To: Elia Pinto; +Cc: git
Elia Pinto <gitter.spiros@gmail.com> writes:
> Add missing headers to prevent ill-effects from multiple inclusion.
>
> Found by the LGTM source code analyzer.
>
> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> ---
> kwset.h | 4 ++++
> tar.h | 5 +++++
> 2 files changed, 9 insertions(+)
Makes sense; thanks.
> diff --git a/kwset.h b/kwset.h
> index df99a92178..f50ecae573 100644
> --- a/kwset.h
> +++ b/kwset.h
> @@ -1,3 +1,6 @@
> +#ifndef KWSET_H
> +#define KWSET_H
> +
> /* This file has been copied from commit e7ac713d^ in the GNU grep git
> * repository. A few small changes have been made to adapt the code to
> * Git.
> @@ -59,3 +62,4 @@ size_t kwsexec(kwset_t, char const *, size_t, struct kwsmatch *);
> /* Deallocate the given keyword set and all its associated storage. */
> void kwsfree(kwset_t);
>
> +#endif /* KWSET_H */
> diff --git a/tar.h b/tar.h
> index 3467705e9b..6b258c4d4a 100644
> --- a/tar.h
> +++ b/tar.h
> @@ -1,3 +1,6 @@
> +#ifndef TAR_H
> +#define TAR_H
> +
> #define TYPEFLAG_AUTO '\0'
> #define TYPEFLAG_REG '0'
> #define TYPEFLAG_LNK '2'
> @@ -23,3 +26,5 @@ struct ustar_header {
> char devminor[8]; /* 337 */
> char prefix[155]; /* 345 */
> };
> +
> +#endif /* TAR_H */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-07 11:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 10:12 [PATCH] kset.h, tar.h: add missing header guard to prevent multiple inclusion Elia Pinto
2019-11-07 11:11 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).