From: Junio C Hamano <gitster@pobox.com>
To: Josh Holland <anowlcalledjosh@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] userdiff: support Python async functions
Date: Wed, 20 Nov 2019 12:59:02 +0900 [thread overview]
Message-ID: <xmqqeey3ci61.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191119150807.8206-1-anowlcalledjosh@gmail.com> (Josh Holland's message of "Tue, 19 Nov 2019 15:08:10 +0000")
Josh Holland <anowlcalledjosh@gmail.com> writes:
> This patch now includes tests for indented declarations, as well as the
> unindented versions which were present before.
Very much appreciated.
I wondered if something like
diff --git a/t/t4018/python-indented-async-def b/t/t4018/python-indented-async-def
index f5d03258af..567c1dafcb 100644
--- a/t/t4018/python-indented-async-def
+++ b/t/t4018/python-indented-async-def
@@ -1,3 +1,6 @@
+async def not_this_one(self):
+ return []
+
class Foo:
async def RIGHT(self, x: int):
return [
would further help, but if a breakage makes us ignore a start of
definition that is indented, we would hit "class Foo:" you added
and notice such a breakage anyway, without additional definition
before it. So I think what we see in this patch is good.
Thanks.
> ...
> t/t4018/python-indented-async-def | 7 +++++++
> ...
> diff --git a/t/t4018/python-indented-async-def b/t/t4018/python-indented-async-def
> new file mode 100644
> index 000000000..f5d03258a
> --- /dev/null
> +++ b/t/t4018/python-indented-async-def
> @@ -0,0 +1,7 @@
> +class Foo:
> + async def RIGHT(self, x: int):
> + return [
> + 1,
> + 2,
> + ChangeMe,
> + ]
> ...
next prev parent reply other threads:[~2019-11-20 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 15:08 [PATCH v2] userdiff: support Python async functions Josh Holland
2019-11-20 3:59 ` Junio C Hamano [this message]
2019-11-20 6:48 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeey3ci61.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=anowlcalledjosh@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).