From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 1E6BA1F463 for ; Fri, 20 Dec 2019 21:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727504AbfLTVfA (ORCPT ); Fri, 20 Dec 2019 16:35:00 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:60716 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727489AbfLTVfA (ORCPT ); Fri, 20 Dec 2019 16:35:00 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id BB3013A473; Fri, 20 Dec 2019 16:34:57 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=FVrUy/4eKEvev2jtWmrxudpQf0E=; b=D61B2U XZOc2bn5wFhoUTidwIExJBl+22geFIh6RhI791WDGHRFwvsJEu87fC+I7qCpoWS+ hUvOMJO9gObqN8y4hLwU58m4zNAwl3rv3PhOnZf17RqpPdoDYzcBtF09GZH8AlFw +uCu9BJ+RESiqesr6q0HU2swQRzOp6EMP4tUo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=CS//TS1v3GmPt/ov5sbPXFzAeYYUqvHQ bmTSjJubxJu39pMB8H2h46nJvdCFZwmZ9+35MNELujLEePsYvPaa0OBtZtceVnHi a4j8CMpOr12sdIDaqrAdJxVCCp2NU2rHqgRXfpZM0vQRZyVg+x3v5TBMDXDcnClN rMJCRzYsWZo= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id B0E1E3A472; Fri, 20 Dec 2019 16:34:57 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.76.80.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 172293A470; Fri, 20 Dec 2019 16:34:57 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Elijah Newren via GitGitGadget" Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de, phillip.wood@dunelm.org.uk, liu.denton@gmail.com, plroskin@gmail.com, Elijah Newren Subject: Re: [PATCH 03/15] rebase, sequencer: remove the broken GIT_QUIET handling References: Date: Fri, 20 Dec 2019 13:34:55 -0800 In-Reply-To: (Elijah Newren via GitGitGadget's message of "Fri, 20 Dec 2019 17:09:36 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 9168E762-2370-11EA-B73E-C28CBED8090B-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Elijah Newren via GitGitGadget" writes: > From: Elijah Newren > > The GIT_QUIET environment variable was used to signal the non-am > backends that the rebase should perform quietly. The preserve-merges > backend does not make use of the quiet flag anywhere (other than to > write out its state whenever it writes state), and this mechanism was > broken in the conversion from shell to C. Since this environment > variable was specifically designed for scripts and the only backend that > would still use it is no longer a script, just gut this code. Nice to see a useless code go ;-)