From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: jn/experimental-opts-into-proto-v2, was Re: What's cooking in git.git (May 2020, #09; Tue, 26)
Date: Wed, 27 May 2020 17:43:18 -0700 [thread overview]
Message-ID: <xmqqeer46g9l.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200527235808.GD56118@google.com> (Jonathan Nieder's message of "Wed, 27 May 2020 16:58:08 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
>> I have been wondering about the same thing, and if it were not using
>> its own custom way to read the configuration, it would have been a
>> non-brainer to merge it down before the release.
>
> Hm, do you have more detail about this? git_config_get_bool feels
> very standard and non-custom.
>
> Do you mean that you would like it to go in repo-settings.c?
No. I fully accept your reasoning in the proposed log message why a
handcrafted query to the config system is done in the location the
patch adds a call. There is nothing wrong with the patch.
But that means that the way it uses the "experimental" variable is
different from the battle-tested way it has been used, which makes
it less than "non-brainer". It may not be risky after all, but
still. This late in the cycle, the fewer things we need to worry
about, the better.
>
>> But this late in
>> the cycle, I'd rather not.
>
> Sure, I can understand.
>
> Would this be something to put on "master" soon after the release?
That was exactly what I had in mind.
next prev parent reply other threads:[~2020-05-28 0:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 18:47 What's cooking in git.git (May 2020, #09; Tue, 26) Junio C Hamano
2020-05-27 3:27 ` jn/experimental-opts-into-proto-v2, was " Johannes Schindelin
2020-05-27 21:49 ` Junio C Hamano
2020-05-27 23:58 ` Jonathan Nieder
2020-05-28 0:43 ` Junio C Hamano [this message]
2020-05-27 20:05 ` Johannes Schindelin
2020-05-28 14:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeer46g9l.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).