From: Junio C Hamano <gitster@pobox.com>
To: randall.s.becker@rogers.com
Cc: git@vger.kernel.org, "Randall S. Becker" <rsbecker@nexbridge.com>
Subject: Re: [Patch v1 2/3] strbuf.c: remove unreferenced strbuf_write_fd method.
Date: Fri, 19 Jun 2020 12:30:52 -0700 [thread overview]
Message-ID: <xmqqeeqahmz7.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200619150445.4380-3-randall.s.becker@rogers.com> (randall s. becker's message of "Fri, 19 Jun 2020 11:04:44 -0400")
randall.s.becker@rogers.com writes:
> From: "Randall S. Becker" <rsbecker@nexbridge.com>
>
> strbuf_write_fd was only used in bugreport.c. Since that file now uses
> write_in_full, this method is no longer needed.
Yay!
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
> strbuf.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/strbuf.c b/strbuf.c
> index 2f1a7d3209..e3397cc4c7 100644
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -556,11 +556,6 @@ ssize_t strbuf_write(struct strbuf *sb, FILE *f)
> return sb->len ? fwrite(sb->buf, 1, sb->len, f) : 0;
> }
>
> -ssize_t strbuf_write_fd(struct strbuf *sb, int fd)
> -{
> - return sb->len ? write(fd, sb->buf, sb->len) : 0;
> -}
> -
> #define STRBUF_MAXLINK (2*PATH_MAX)
>
> int strbuf_readlink(struct strbuf *sb, const char *path, size_t hint)
next prev parent reply other threads:[~2020-06-19 19:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200619150445.4380-1-randall.s.becker.ref@rogers.com>
2020-06-19 15:04 ` [Patch v1 0/3] Replace strbuf_write_fd with write_in_full randall.s.becker
2020-06-19 15:04 ` [Patch v1 1/3] bugreport.c: replace " randall.s.becker
2020-06-19 16:35 ` Đoàn Trần Công Danh
2020-06-19 17:17 ` Randall S. Becker
2020-06-19 19:30 ` Junio C Hamano
2020-06-19 19:37 ` Randall S. Becker
2020-06-19 23:01 ` Đoàn Trần Công Danh
2020-06-19 23:26 ` Randall S. Becker
2020-06-19 19:47 ` Jeff King
2020-06-19 15:04 ` [Patch v1 2/3] strbuf.c: remove unreferenced strbuf_write_fd method randall.s.becker
2020-06-19 19:30 ` Junio C Hamano [this message]
2020-06-19 19:49 ` Jeff King
2020-06-19 15:04 ` [Patch v1 3/3] strbuf.h: remove declaration of deprecated " randall.s.becker
2020-06-19 19:31 ` Junio C Hamano
2020-06-19 19:34 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeeqahmz7.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=randall.s.becker@rogers.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).