git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>,
	Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH] experimental: default to fetch.writeCommitGraph=false
Date: Tue, 07 Jul 2020 09:50:00 -0700	[thread overview]
Message-ID: <xmqqeepn5kxz.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200707151735.GA27992@syl.lan> (Taylor Blau's message of "Tue, 7 Jul 2020 11:17:35 -0400")

Taylor Blau <me@ttaylorr.com> writes:

>> I wonder if we perhaps wnat to add to the documentation for
>> writeCommitGraph configuration that its use is currently not
>> recommended in a shallow clone or something (I know it is not
>> a problem just to use it with shallow but the breakage needs
>> to involve unshallowing, but by definition those who do not
>> use shallow would not hit the unshallowing bug, so...).
>
> I think this is a good direction if you don't want to take the patch I
> sent in [1] for v2.28.0. If you do, though, I don't think that this
> would be necessary.

Good timing.  I didn't know a "fix" was already being worked on ([1]
is the patch from this morning, right?  I haven't seen it except for
its subject).

We could obviously do both excluding it from the usual experimental
set and applying your fix, so that those who are really curious can
help us make sure your fix would be all that is needed.  Let's see
what Jonathan says...

Thanks.

  reply	other threads:[~2020-07-07 16:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07  6:20 [PATCH] experimental: default to fetch.writeCommitGraph=false Jonathan Nieder
2020-07-07 13:24 ` Derrick Stolee
2020-07-07 15:09 ` Junio C Hamano
2020-07-07 15:17   ` Taylor Blau
2020-07-07 16:50     ` Junio C Hamano [this message]
2020-07-07 16:53       ` Taylor Blau
2020-07-08  5:47       ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeepn5kxz.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=jrnieder@gmail.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).