From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, martin.agren@gmail.com,
sandals@crustytoothpaste.net, me@ttaylorr.com,
abhishekkumar8222@gmail.com,
Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH 0/3] SHA-256: Update commit-graph and multi-pack-index formats
Date: Fri, 14 Aug 2020 12:25:47 -0700 [thread overview]
Message-ID: <xmqqeeo9vxl0.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.703.git.1597428440.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Fri, 14 Aug 2020 18:07:17 +0000")
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> As discussed [1], there is some concern around binary file formats requiring
> the context of the repository config in order to infer hash lengths. Two
> formats that were designed with the hash transition in mind (commit-graph
> and multi-pack-index) have bytes available to indicate the hash algorithm
> used. Let's actually update these formats to be more self-contained with the
> two hash algorithms being available.
> ...
> If this is the way we want to go with the formats, then I'll assist
> coordinating these textual and semantic merge conflicts.
I agree that the files should be self-identifying, but have these
changes tested without sha256 hash?
next prev parent reply other threads:[~2020-08-14 19:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 18:07 [PATCH 0/3] SHA-256: Update commit-graph and multi-pack-index formats Derrick Stolee via GitGitGadget
2020-08-14 18:07 ` [PATCH 1/3] t/README: document GIT_TEST_DEFAULT_HASH Derrick Stolee via GitGitGadget
2020-08-14 19:02 ` Junio C Hamano
2020-08-14 20:39 ` Eric Sunshine
2020-08-14 20:41 ` Derrick Stolee
2020-08-14 18:07 ` [PATCH 2/3] commit-graph: use the hash version byte Derrick Stolee via GitGitGadget
2020-08-14 19:05 ` Junio C Hamano
2020-08-14 20:05 ` Taylor Blau
2020-08-14 20:11 ` brian m. carlson
2020-08-14 20:22 ` Junio C Hamano
2020-08-14 20:36 ` Derrick Stolee
2020-08-15 13:46 ` Martin Ågren
2020-08-14 18:07 ` [PATCH 3/3] multi-pack-index: use " Derrick Stolee via GitGitGadget
2020-08-14 20:14 ` brian m. carlson
2020-08-14 19:25 ` Junio C Hamano [this message]
2020-08-14 20:34 ` [PATCH 0/3] SHA-256: Update commit-graph and multi-pack-index formats Derrick Stolee
2020-08-14 21:41 ` Junio C Hamano
2020-08-17 14:04 ` [PATCH v2 " Derrick Stolee via GitGitGadget
2020-08-17 14:04 ` [PATCH v2 1/3] t/README: document GIT_TEST_DEFAULT_HASH Derrick Stolee via GitGitGadget
2020-08-17 14:04 ` [PATCH v2 2/3] commit-graph: use the "hash version" byte Derrick Stolee via GitGitGadget
2020-08-17 14:04 ` [PATCH v2 3/3] multi-pack-index: use hash version byte Derrick Stolee via GitGitGadget
2020-08-17 23:12 ` [PATCH v2 0/3] SHA-256: Update commit-graph and multi-pack-index formats brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeeo9vxl0.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=abhishekkumar8222@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=martin.agren@gmail.com \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).