From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Hariom Verma via GitGitGadget <gitgitgadget@gmail.com>,
Git List <git@vger.kernel.org>,
Hariom Verma <hariom18599@gmail.com>
Subject: Re: [PATCH v2 2/2] ref-filter: 'contents:trailers' show error if `:` is missing
Date: Fri, 21 Aug 2020 12:17:36 -0700 [thread overview]
Message-ID: <xmqqeenz95bj.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cRxCvHG70Nd00zBxYFuecu6+Z6uDP8ooN3rx9vPagoYBA@mail.gmail.com> (Eric Sunshine's message of "Fri, 21 Aug 2020 12:56:56 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> ...an alternative would have been something like:
>
> else if (!strcmp(arg, "trailers")) {
> if (trailers_atom_parser(format, atom, NULL, err))
> return -1;
> } else if (skip_prefix(arg, "trailers:", &arg)) {
> if (trailers_atom_parser(format, atom, arg, err))
> return -1;
> }
>
> which is quite simple to reason about (though has the cost of a tiny
> bit of duplication).
Yeah, that looks quite simple and straight-forward.
>> diff --git a/t/t6300-for-each-ref.sh b/t/t6300-for-each-ref.sh
>> @@ -823,6 +823,15 @@ test_expect_success '%(trailers) rejects unknown trailers arguments' '
>> +test_expect_success 'if arguments, %(contents:trailers) shows error if semicolon is missing' '
>
> s/semicolon/colon/
Definitely.
>
>> + # error message cannot be checked under i18n
>
> What is this comment about? I realize that you copied it from other
> nearby tests, but I find that it muddies rather than clarifies.
Yup. If a patch changes test_cmp with test_i18ncmp, the above
message belongs to its commit log message, but it is overkill to
have it as an in-line comment in every place where test_i18ncmp gets
used.
Thanks for a review.
>> + cat >expect <<-EOF &&
>> + fatal: unrecognized %(contents) argument: trailersonly
>> + EOF
>> + test_must_fail git for-each-ref --format="%(contents:trailersonly)" 2>actual &&
>> + test_i18ncmp expect actual
>> +'
next prev parent reply other threads:[~2020-08-21 19:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 12:52 [PATCH 0/2] Fix trailers atom bug and improved tests Hariom Verma via GitGitGadget
2020-08-19 12:52 ` [PATCH 1/2] t6300: unify %(trailers) and %(contents:trailers) tests Hariom Verma via GitGitGadget
2020-08-19 17:31 ` Junio C Hamano
2020-08-21 10:03 ` Hariom verma
2020-08-19 12:52 ` [PATCH 2/2] ref-filter: 'contents:trailers' show error if `:` is missing Hariom Verma via GitGitGadget
2020-08-19 17:55 ` Junio C Hamano
2020-08-19 19:07 ` Junio C Hamano
2020-08-19 19:39 ` Eric Sunshine
2020-08-19 22:08 ` Junio C Hamano
2020-08-20 17:19 ` Hariom verma
2020-08-21 10:11 ` [PATCH v2 0/2] Fix trailers atom bug and improved tests Hariom Verma via GitGitGadget
2020-08-21 10:11 ` [PATCH v2 1/2] t6300: unify %(trailers) and %(contents:trailers) tests Hariom Verma via GitGitGadget
2020-08-21 10:11 ` [PATCH v2 2/2] ref-filter: 'contents:trailers' show error if `:` is missing Hariom Verma via GitGitGadget
2020-08-21 16:56 ` Eric Sunshine
2020-08-21 19:17 ` Junio C Hamano [this message]
2020-08-23 19:25 ` Hariom verma
2020-08-24 3:49 ` Eric Sunshine
2020-08-24 23:32 ` Hariom verma
2020-08-26 6:18 ` Christian Couder
2020-08-26 6:22 ` Christian Couder
2020-08-26 15:18 ` Hariom verma
2020-08-21 21:06 ` [PATCH v3 0/4] [GSoC] Fix trailers atom bug and improved tests Hariom Verma via GitGitGadget
2020-08-21 21:06 ` [PATCH v3 1/4] t6300: unify %(trailers) and %(contents:trailers) tests Hariom Verma via GitGitGadget
2020-08-21 21:06 ` [PATCH v3 2/4] ref-filter: 'contents:trailers' show error if `:` is missing Hariom Verma via GitGitGadget
2020-08-21 21:13 ` Eric Sunshine
2020-08-21 16:19 ` Hariom verma
2020-08-21 21:54 ` Junio C Hamano
2020-08-21 21:06 ` [PATCH v3 3/4] pretty.c: refactor trailer logic to `format_set_trailers_options()` Hariom Verma via GitGitGadget
2020-08-21 21:06 ` [PATCH v3 4/4] ref-filter: using pretty.c logic for trailers Hariom Verma via GitGitGadget
2020-08-21 21:56 ` [PATCH v3 0/4] [GSoC] Fix trailers atom bug and improved tests Junio C Hamano
2020-08-22 14:03 ` Hariom verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeenz95bj.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hariom18599@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).