From: Junio C Hamano <gitster@pobox.com>
To: "Sohom Datta via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>,
Sohom Datta <sohom.datta@learner.manipal.edu>
Subject: Re: [PATCH v2] userdiff: expand detected chunk headers for css
Date: Thu, 08 Oct 2020 10:23:42 -0700 [thread overview]
Message-ID: <xmqqeem8y6ld.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.866.v2.git.git.1602146164799.gitgitgadget@gmail.com> (Sohom Datta via GitGitGadget's message of "Thu, 08 Oct 2020 08:36:04 +0000")
"Sohom Datta via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Sohom <sohom.datta@learner.manipal.edu>
I'd call this line *1* for later reference...
> The regex used for the CSS builtin diff driver in git is only
> able to show chunk headers for lines that start with a number,
> a letter or an underscore.
>
> However, the regex fails to detect classes (starts with a .), ids
> (starts with a #), :root and attribute-value based selectors (for
> example [class*="col-"]), as well as @based block-level statements
> like @page,@keyframes and @media since all of them, start with a
> special character.
>
> Allow the selectors and block level statements to begin with these
> special characters.
>
> Signed-off-by: Sohom Datta <sohom.datta@learner.manipal.edu>
> ---
Looking good.
The "Name <email>" on line *1* must match that on the last
"signed-off-by" line, so I'll locally tweak the authorship information
before applying the patch.
Thanks.
prev parent reply other threads:[~2020-10-08 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 9:25 [PATCH] userdiff: expand detected chunk headers for css Sohom Datta via GitGitGadget
2020-10-07 16:51 ` Johannes Sixt
2020-10-07 17:09 ` Junio C Hamano
2020-10-08 8:36 ` [PATCH v2] " Sohom Datta via GitGitGadget
2020-10-08 17:23 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeem8y6ld.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=j6t@kdbg.org \
--cc=sohom.datta@learner.manipal.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).