From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 9E0021F66F for ; Thu, 5 Nov 2020 23:05:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732369AbgKEXFr (ORCPT ); Thu, 5 Nov 2020 18:05:47 -0500 Received: from pb-smtp21.pobox.com ([173.228.157.53]:54233 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731694AbgKEXFr (ORCPT ); Thu, 5 Nov 2020 18:05:47 -0500 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 7973C102B20; Thu, 5 Nov 2020 18:05:45 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=rEvUB2wuBP73v5wO1DNmKfe2gPY=; b=HSX9Bu 9XJvFqFWkSE1mkVgMhLHVu0iLHf8TFII4gMcqo625t3BuQlvdjNjp2PMK8em0Nax 32X984oTRwiVjPXno/2z/h1y302loP/HA8FYmtY6mB83lseshj51XquwaHzShxW1 P7QW5hKqcTvuyKTWf/cZ62Q1hfsRCXQ7FWDRs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=qPbQUMWhMRmIMH8EjzlOvIqkKhuVwHh9 F5voOiNHSAw45PeiZL7ovZY8hAzxJVRSbidEWNROhNd/kl4xRR5IuB4rZKc7Jc4f izbt/FKB0cqfXO5phDjT1QmZvO0V75oHw4uCLs7sTVPwz0B1jEbB4HHNxK1T9wQu xsPXz6PGFxM= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 7200A102B1F; Thu, 5 Nov 2020 18:05:45 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id A634E102B1E; Thu, 5 Nov 2020 18:05:42 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Ramsay Jones Cc: GIT Mailing-list Subject: Re: [PATCH 7/8] Makefile: don't delete dist tarballs directly by name References: <48fdd198-93ad-7282-27e6-9a0c6de93067@ramsayjones.plus.com> Date: Thu, 05 Nov 2020 15:05:40 -0800 In-Reply-To: (Junio C. Hamano's message of "Thu, 05 Nov 2020 14:01:54 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 6DD4C9FE-1FBB-11EB-BEA0-D609E328BF65-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > Ramsay Jones writes: > >> diff --git a/.gitignore b/.gitignore >> index 6232d33924..425b8cc2a4 100644 >> --- a/.gitignore >> +++ b/.gitignore >> @@ -191,6 +191,7 @@ >> /gitweb/static/gitweb.min.* >> /config-list.h >> /command-list.h >> +/dist-tars >> *.tar.gz >> *.dsc >> *.deb >> diff --git a/Makefile b/Makefile >> index 90e91a2185..bc9ce28bc3 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -3083,6 +3083,7 @@ dist: git-archive$(X) configure >> --prefix=$(GIT_TARNAME)/ HEAD^{tree} > $(GIT_TARNAME).tar >> @$(RM) -r .dist-tmp-dir >> gzip -f -9 $(GIT_TARNAME).tar >> + @echo $(GIT_TARNAME).tar.gz >>dist-tars > > Sorry, but I'd rather not to see such a longer-term "list of files > to be removed" on the filesystem. This invites attackers to write a > rogue test addition that writes into ../../dist-tars something like > "~/.gitconfig" and wait for me to say "make clean". Having said that, I also think that "make clean" target should help your desire to keep tarballs that would not have been generated by the current checkout (e.g. the last release), and I do not think $(RM) git-htmldocs-*.tar.gz git-manpages-*.tar.gz is an unconditionally better alternative to what you did in this step. How about moving removal of these "distribution" artifacts that are created by "make dist$something" targets from "clean" to "distclean"?