From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 66C001F934 for ; Mon, 11 Jan 2021 21:07:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730977AbhAKVG4 (ORCPT ); Mon, 11 Jan 2021 16:06:56 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:61252 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730488AbhAKVG4 (ORCPT ); Mon, 11 Jan 2021 16:06:56 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 67494123000; Mon, 11 Jan 2021 16:06:14 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=Q3qjMIPOb7xA /J5+J8EuvQo0Aps=; b=NKqjELob5h3P3CMTrj9z0AWVRj774VBG3/rMFD+yzquV vp0OF0lreY0jWUtd4ZvPGnI1EXJlYVFTdZb0jbIt38t0jVsqhy7wIbkMSpYg8KEg zrZqGDFZtwTioGsZVLJuArCcmCFvJ06DG8eaxK5Z5PjoShiD9NHQOWkW1uqiLic= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=Yap7rk pZnesb6RTbHfC8CoCMcDtNXaYXFZAPJJ/u50N/wRzPCc0hsM2/f4672kzKq0a0zq 8fZDXXzEzY0Tn6dBqn1umhNeeGYqUIeQaIRFAEHYeZB9WCoEf0P0LpxiuX/bAHA5 4yZOfmNZ/FC8trCrSV+lHbDDBsiER9mtKCiMI= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 5FC2C122FFF; Mon, 11 Jan 2021 16:06:14 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.173.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id A7B8D122FFE; Mon, 11 Jan 2021 16:06:11 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, SZEDER =?utf-8?Q?G=C3=A1bor?= , Johannes Schindelin , =?utf-8?B?Tmd1eeG7hW4gVGjDoWkg?= =?utf-8?B?Tmfhu41j?= Duy Subject: Re: [PATCH 0/2] Makefile & gettext.c: remove warning & long comment References: <87pn2b6eyb.fsf@evledraar.gmail.com> <20210111131451.7084-1-avarab@gmail.com> Date: Mon, 11 Jan 2021 13:06:10 -0800 In-Reply-To: <20210111131451.7084-1-avarab@gmail.com> (=?utf-8?B?IsOGdmFy?= =?utf-8?B?IEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Mon, 11 Jan 2021 14:14:49 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: D543AF96-5450-11EB-B776-E43E2BB96649-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > We've got a huge comment in gettext.c that nobody cares about anymore, > remove it, and an old warning in the Makefile while I'm at it. > > This doesn't conflict with any other patches I'm about to submit, I > wanted to submit it separately because these are small isolated > non-contentious changes. Both look sensible. Thanks, will queue. > =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason (2): > Makefile: remove a warning about old GETTEXT_POISON flag > gettext.c: remove/reword a mostly-useless comment > > Makefile | 3 -- > gettext.c | 94 +++++++++---------------------------------------------- > 2 files changed, 15 insertions(+), 82 deletions(-)