From: Junio C Hamano <email@example.com>
To: Felipe Contreras <firstname.lastname@example.org>
Cc: email@example.com, "Martin Ågren" <firstname.lastname@example.org>,
"brian m . carlson" <email@example.com>
Subject: Re: [PATCH v2 00/12] doc: cleanup old cruft and asciidoctor revamp
Date: Tue, 25 May 2021 16:14:29 +0900 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
In-Reply-To: <email@example.com> (Junio C. Hamano's message of "Tue, 25 May 2021 15:59:17 +0900")
Junio C Hamano <firstname.lastname@example.org> writes:
> Felipe Contreras <email@example.com> writes:
>> Apparently my scripts call `git format-patch` with -D, which doesn't
>> generate appliable patches when files are deleted.
> Don't call format-patch with -D, then ;-).
>> Do you want me to send it again without -D?
> Sure, if a collection of patches want to be reviewed and applied, I
> would think it helps for them to be appliable to a common tree (like
> my 'master') with tools reviewers and the maintainer are know to use
> (like "git am"). As more roadblocks are added before the changes
> can become reviewable in the reviewers' trees, less chances they
> have to get reviewed.
Oh, I didn't answer the question. Do I want you (or anybody) to?
Not really, especially during the pre-release freeze period.
I wasn't heavily involved in the "let's use asciidoctor-native to
bypass xmlto" or "asciidoc is not exactly abandoned, but we should
prepare ourselves to make asciidoctor the default" discussion, but
I've seen people I trust voice their opinion and trust them enough
to believe that a concensus among them would lead to an acceptable
future, so I'd rather stand on the sideline, and see people discuss
and come up with a concensus before I pick the final product when
the next cycle opens.
And it would help to make sure reviewers can pick it up and apply it
to their trees, if a patch series, even as a discussion material and
not a final submission, wants to lead to such a concensus.
next prev parent reply other threads:[~2021-05-25 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 22:36 [PATCH v2 00/12] doc: cleanup old cruft and asciidoctor revamp Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 01/12] doc: remove GNU troff workaround Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 02/12] doc: use --stringparam in xmlto Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 03/12] doc: simplify version passing Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 04/12] doc: asciidoc: remove unnecessary attribute Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 05/12] doc: asciidoctor: remove unnecessary require Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 06/12] doc: asciidoctor: remove cruft Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 07/12] doc: asciidoctor: reorganize extensions Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 08/12] doc: asciidoctor: use html-prefix only for html Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 09/12] doc: asciidoctor: refactor macro registration Felipe Contreras
2021-05-21 22:36 ` [PATCH v2 10/12] doc: asciidoctor: improve string handling Felipe Contreras
2021-05-21 22:37 ` [PATCH v2 11/12] doc: asciidoctor: split the format from the code Felipe Contreras
2021-05-21 22:37 ` [PATCH v2 12/12] doc: asciidoctor: specify name of our group Felipe Contreras
2021-05-24 18:01 ` [PATCH v2 00/12] doc: cleanup old cruft and asciidoctor revamp Junio C Hamano
2021-05-24 19:23 ` Felipe Contreras
2021-05-25 6:59 ` Junio C Hamano
2021-05-25 7:14 ` Junio C Hamano [this message]
2021-05-25 10:44 ` Felipe Contreras
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).