From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 228261F670 for ; Fri, 15 Oct 2021 15:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241073AbhJOP7s (ORCPT ); Fri, 15 Oct 2021 11:59:48 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:56485 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233273AbhJOP7s (ORCPT ); Fri, 15 Oct 2021 11:59:48 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 2917615E56D; Fri, 15 Oct 2021 11:57:41 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=SliXFbd5R8JfyT9SCUo6lcqoliwcTqQLKnUNOT J/o+U=; b=Q/DPqSq50feZYrQokNNgRvyl6BOkSFn6IblfV2i43sENR3nTUNbByM 4LpMHauK0iWm5NB10r9pmIOvb4HZ3jrVnMwpS1eB6aukxbc1vSIZAzWH8mCWRu++ y2b0Au2StFcR8CQL3rxBV1mYowAbqTq0SfnA/O0hxkFpBA6k8jRa4= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 20E4915E56C; Fri, 15 Oct 2021 11:57:41 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 5138C15E56B; Fri, 15 Oct 2021 11:57:38 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Derrick Stolee Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Glen Choo , git@vger.kernel.org, Eric Sunshine , Taylor Blau , Derrick Stolee Subject: Re: [PATCH v4 0/3] Use default values from settings instead of config References: <20211005001931.13932-1-chooglen@google.com> <20211012174208.95161-1-chooglen@google.com> <87wnmihswp.fsf@evledraar.gmail.com> <02947b5e-7ce3-4760-0d27-621c7362f839@gmail.com> <87pms8hq4s.fsf@evledraar.gmail.com> Date: Fri, 15 Oct 2021 08:57:37 -0700 In-Reply-To: (Junio C. Hamano's message of "Thu, 14 Oct 2021 15:25:04 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 9EDEDC5A-2DD0-11EC-AABB-98D80D944F46-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > Derrick Stolee writes: > >> I generally consider any interaction with the commit-graph while >> replace refs are enabled to be the bug. We don't read the commit-graph >> when replace refs are on, so why are we verifying it? >> >> But, I understand the desire to check the on-disk content even though >> it is not being used, so disabling replace refs to do the verify should >> be sufficient. > > That's quite a sensible argument. Sounds like we have a way to > solve this that everybody agrees with. Would it be sensible to silently ignore, though? Would a warning, when we see replacement is in use and an explicit request by an end user is made to make use of or update the commit-graph, be too loud?