From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS,URIBL_CSS, URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 855DC1F953 for ; Wed, 3 Nov 2021 23:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229652AbhKDAA0 (ORCPT ); Wed, 3 Nov 2021 20:00:26 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:50742 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbhKDAAZ (ORCPT ); Wed, 3 Nov 2021 20:00:25 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 33594168359; Wed, 3 Nov 2021 19:57:48 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type :content-transfer-encoding; s=sasl; bh=teIAV58feZYbvMy1x6Xmojw2w LrauUfSVE1g0DJTjXs=; b=ucggGgu1oBcBPo7kAZYjqSRFZ+QgmrPhEpvUKnyJi 8FP5O8OHjKp9YxFZF+uNSrzevVfQIfxtQqknVNpNrmoqhRydq8MrHJYNphHwvWch ONxfwNVrazVAvkf1p9A9e+H2+aEFG/gemi6i10z3yRkDca8/7X7krbRfxFRCm1Hh us= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 2B688168358; Wed, 3 Nov 2021 19:57:48 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 2CC38168357; Wed, 3 Nov 2021 19:57:43 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Jeff King , Andrzej Hunt , =?utf-8?B?TMOpbmHDr2M=?= Huard , Derrick Stolee , Felipe Contreras , SZEDER =?utf-8?Q?G=C3=A1bor?= , =?utf-8?B?xJBv?= =?utf-8?B?w6BuIFRy4bqnbiBDw7RuZw==?= Danh , Carlo Marcelo Arenas =?utf-8?Q?Bel=C3=B3n?= Subject: Re: Re* [PATCH v8 2/2] tests: add a test mode for SANITIZE=leak, run it in CI References: Date: Wed, 03 Nov 2021 16:57:41 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: D5BFD5EA-3D01-11EC-919A-98D80D944F46-77302942!pb-smtp21.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > >> The CI target uses a new GIT_TEST_PASSING_SANITIZE_LEAK=3Dtrue test >> mode. When running in that mode, we'll assert that we were compiled >> with SANITIZE=3Dleak. We'll then skip all tests, except those that we'= ve >> opted-in by setting "TEST_PASSES_SANITIZE_LEAK=3Dtrue". >> ... >> This is how tests that don't set "TEST_PASSES_SANITIZE_LEAK=3Dtrue" wi= ll >> be skipped under GIT_TEST_PASSING_SANITIZE_LEAK=3Dtrue: > > I've been playing with this locally, but cannot shake the nagging > feeling that GIT_TEST_PASSING_SANITIZE_LEAK must default to true. > Otherwise, it is one more thing they need to find out and set when > they do > > make SANITYZE=3Dleak test > > because they want to be a good developer and to ensure that they did > not introduce new leaks. > > If we want to encourage folks to locally run the leak checks before > declaring their own work "done", that is. > > Those who are hunting for and cleaning up existing leaks can and > should set it to false, no? Another thing while I am at it, I have a feeling that the polarity of the TEST_PASSES_SANITIZE_LEAK declaration is the other way around. Marking the tests that do not yet pass the leak check with a special annotation will make it easier to find not-yet-clean tests for those who have too much time on their hands ;-) to find ones that are affected by the leaky tests.