From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,URIBL_CSS, URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id EBC941F54E for ; Wed, 3 Aug 2022 17:13:44 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="rSwc6QCK"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236686AbiHCRNk (ORCPT ); Wed, 3 Aug 2022 13:13:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236054AbiHCRNi (ORCPT ); Wed, 3 Aug 2022 13:13:38 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F6604C613 for ; Wed, 3 Aug 2022 10:13:37 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id C0DB71B6B9F; Wed, 3 Aug 2022 13:13:36 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=mqVV/BYxLg0q 7Y5RVCO5cLThuz4i5/h+0O7RHDb32Dk=; b=rSwc6QCK0irDGGZNz7O0Jge1hvDs E8BGrrZj7SUO9X64KFri8BXI9ahDHZPgbH7HGrNI9bRzXinNIPIlY6bKDkvICtKY fhJiUomWV0OVbxtJogavPCvOg/Pr8wPwqwQ384sZag/6fOoeQX04SGlYgGuhESGy aP9QvJtnIdbWigo= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id BA6F41B6B9E; Wed, 3 Aug 2022 13:13:36 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.145.39.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 605801B6B9D; Wed, 3 Aug 2022 13:13:33 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Jeff King , Eric Sunshine Subject: Re: [PATCH v3 1/6] bisect.c: add missing "goto" for release_revisions() References: Date: Wed, 03 Aug 2022 10:13:32 -0700 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Tue, 2 Aug 2022 17:33:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 9A84D12C-134F-11ED-B279-CBA7845BAAA9-77302942!pb-smtp21.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > Add a missing "goto cleanup", this fixes a bug in > f196c1e908d (revisions API users: use release_revisions() needing > REV_INFO_INIT, 2022-04-13). > > Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason > --- > bisect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bisect.c b/bisect.c > index b63669cc9d7..421470bfa59 100644 > --- a/bisect.c > +++ b/bisect.c > @@ -1054,7 +1054,7 @@ enum bisect_error bisect_next_all(struct reposito= ry *r, const char *prefix) > */ > res =3D error_if_skipped_commits(tried, NULL); > if (res < 0) > - return res; > + goto cleanup; > printf(_("%s was both %s and %s\n"), > oid_to_hex(current_bad_oid), > term_good, OK, from the cleanup: label we call release_revisions(&rev) which was used in the "failed" attempt to find bisection. Looks good.