From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Derrick Stolee" <derrickstolee@github.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Emily Noneman" <emily.noneman@gmail.com>,
"Paul Horn" <git@knutwalker.engineer>
Subject: Re: [PATCH] revision.c: set-up "index_state.repo", don't segfault in pack-objects
Date: Tue, 09 Aug 2022 09:55:03 -0700 [thread overview]
Message-ID: <xmqqedxpqrvc.fsf@gitster.g> (raw)
In-Reply-To: <YvJZCGyhd6KJCabi@coredump.intra.peff.net> (Jeff King's message of "Tue, 9 Aug 2022 08:54:32 -0400")
Jeff King <peff@peff.net> writes:
> Here's the test addition you mentioned, though I'm really not sure it's
> adding much. The source lines for both the bug/fix and the spot where we
> segfault should be identical between the two cases. It's really just
> about how we ended up calling into the code.
True, but the "non-existing index file" case is rare enough that it
would be worth to document the new way to get into the state, I
would think.
I am offline every other Tuesday and today is such a day,
so please expect no changes to the public repositories.
Thanks.
> t/t7063-status-untracked-cache.sh | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/t/t7063-status-untracked-cache.sh b/t/t7063-status-untracked-cache.sh
> index c1f0d95036..a0e8920ffa 100755
> --- a/t/t7063-status-untracked-cache.sh
> +++ b/t/t7063-status-untracked-cache.sh
> @@ -990,4 +990,9 @@ test_expect_success 'empty repo (no index) and core.untrackedCache' '
> git -C emptyrepo -c core.untrackedCache=true write-tree
> '
>
> +test_expect_success 'empty worktree and core.untrackedCache' '
> + git worktree add --no-checkout empty-worktree &&
> + git -c core.untrackedCache=true gc
> +'
> +
> test_done
prev parent reply other threads:[~2022-08-09 16:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 8:51 Bugreport: pack-objects died of signal 11 Paul Horn
2022-07-14 21:37 ` Jeff King
2022-08-04 18:21 ` Emily Noneman
2022-08-04 20:14 ` Derrick Stolee
2022-08-04 21:07 ` Ævar Arnfjörð Bjarmason
2022-08-04 22:32 ` Emily Noneman
2022-08-05 14:24 ` [PATCH] revision.c: set-up "index_state.repo", don't segfault in pack-objects Ævar Arnfjörð Bjarmason
2022-08-05 14:48 ` Derrick Stolee
2022-08-05 15:25 ` Jeff King
2022-08-05 16:41 ` Junio C Hamano
2022-08-08 18:15 ` Emily Noneman
2022-08-09 12:55 ` Jeff King
2022-08-09 16:56 ` Junio C Hamano
2022-08-09 12:54 ` Jeff King
2022-08-09 16:55 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedxpqrvc.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=emily.noneman@gmail.com \
--cc=git@knutwalker.engineer \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).