From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 7FEA21F45A for ; Wed, 26 Oct 2022 19:15:19 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lmLvrGzj"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235065AbiJZTPQ (ORCPT ); Wed, 26 Oct 2022 15:15:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235073AbiJZTOt (ORCPT ); Wed, 26 Oct 2022 15:14:49 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3D8725EBE for ; Wed, 26 Oct 2022 12:13:27 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id 3-20020a17090a0f8300b00212d5cd4e5eso3628947pjz.4 for ; Wed, 26 Oct 2022 12:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=q6K+mQYeeMpaNYdI7t89iJFQpP/7bMTYZpLdTBNQUPY=; b=lmLvrGzjyN83FNYPdQ6410aqxTx+cvchAqUInZLGRgxPyTfLoz8DADYG0BPviFlvCt g70oKZboj/tAo6/EbcjdBR/IoZR/hqrh7C/i2n0+xdj1kCK5TWgyoTzz1N26BgZyUEqM IrnyaopypEwX/0lUD8CLiVIcbInV+2mFsD8xsmF47xU4ZpPyvoPRPZaKpUbeeFlW7bEY nrpV+NSVNHM2KZchyMTxqjAxV8aoBQ6QmTR1UG5Z3ZEzzjJkAccW0Yw1DJK6HcCWomf9 ixK0ZCol5MnSoYkAP0DWYBmcc6YeLeNQ6JzWsNFklxE/Q4qGaW96dsvml2GB1SjpGKOq BoPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q6K+mQYeeMpaNYdI7t89iJFQpP/7bMTYZpLdTBNQUPY=; b=5MMYVWgs0UntaFYhCa7DEVQYGOS8F3ypjDRZ6dENGtv8VLz8I9uDPQsjVJ6ts7tJvO si29m1GTTntirUCpiaT+aJwJKsKrg2Bl+DBfAPorvO6OVaVXGdpiGsRNztoMJsSZh9ON kzos4I5S385uvGQwSufSFy31y4YBpbZC/Q4posDyWmpdQyOasuUJ67SxMBOolP5+t2h/ B0waWdUFYL7cH3jveN0FNhx/sKK8jSDN7jsmat5o6fp3VvKwPBOmtJEKSrygMHJ39gxo +IMi89RVLTQnEZd7/TlL7Tm0Po5jaexbJVMkgtDske5mM3c7jle1fYq/keW5kT4ftEex nlAQ== X-Gm-Message-State: ACrzQf3N+bwauVOVUu5Yry8XDo3l008xv2k5foADwIzAHfZCqcTvzHlI rZb/r21K+taeUa6TpAv7kbg= X-Google-Smtp-Source: AMsMyM7DTAv2XcSrr4OBOXsQnHFyf6BLAr2HwfnTOBk09doi9pg/usGnhNalnnr2ZOtp2gJiaRs+CQ== X-Received: by 2002:a17:902:ea01:b0:186:e4f8:e9e7 with SMTP id s1-20020a170902ea0100b00186e4f8e9e7mr2317618plg.21.1666811607005; Wed, 26 Oct 2022 12:13:27 -0700 (PDT) Received: from localhost (33.5.83.34.bc.googleusercontent.com. [34.83.5.33]) by smtp.gmail.com with ESMTPSA id i6-20020a170902c94600b00186e8526790sm308053pla.127.2022.10.26.12.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 12:13:26 -0700 (PDT) Sender: Junio C Hamano From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Johannes Schindelin , Victoria Dye , Derrick Stolee Subject: Re: [PATCH v2 2/3] Makefile: define "TEST_{PROGRAM,OBJS}" variables earlier References: <221026.86y1t2beoj.gmgdl@evledraar.gmail.com> Date: Wed, 26 Oct 2022 12:13:26 -0700 In-Reply-To: <221026.86y1t2beoj.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Wed, 26 Oct 2022 20:47:43 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Ævar Arnfjörð Bjarmason writes: > On Wed, Oct 26 2022, Junio C Hamano wrote: > >> Ævar Arnfjörð Bjarmason writes: >> >>> Define the variables that make up TEST_OBJS earlier, and don't go back >>> & forth in their definition. Before we'd first append $X to >>> $(TEST_PROGRAMS), and then substitute $X back out of it to define >>> $(TEST_OBJS). Let's instead add a new $(TEST_PROGRAM_OBJS) variable, >>> which avoids this needless back & forth substitution. >> >> Makes sense, I guess. So TEST_OBJS is no longer used? > > Yes, sorry I'll clarify that in a re-roll. It invites the question why it needed to be renamed in the first place, though. If we needed to name something that is different from the original TEST_OBJS, it makes perfect sense to add a variable with a new name, but if it is not the case here, then...? >> Having said that, "all::" being able to be built up with independent >> pieces shine here in this split from the original. It probably is >> easier to reason about while seeing this isolated area of Makefile >> what is being done to TEST_PROGRAMS. > > ...here I'm not quite sure if you want to keep it after all or nat... I'll let it pass this time ;-) but my patience is not infinite.