From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.80.0/22 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [147.75.80.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 2926C1F451 for ; Thu, 18 Jan 2024 00:46:39 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=RNOqGJXa; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 87AE71F23E57 for ; Thu, 18 Jan 2024 00:46:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 02EDB8F42; Thu, 18 Jan 2024 00:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="RNOqGJXa" Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 019F679CD for ; Thu, 18 Jan 2024 00:46:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.108.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705538785; cv=none; b=EttoNcztxMAMWBXkP87wEs0zGUpMZg3Nt7MAwpLuujn9Y6WEvkHjmryEAh1gmCoFXAmPDOnZmoOMqrWF7DptIUk3QpssSJ0cKfWjxL+EvRZhpYOD8gWHgHUspUh7Iw3AniZu0u0AH9qctZFv94PSsUu07kliRXnAqyVSaBZLQMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705538785; c=relaxed/simple; bh=nAYdK49YesM4TJcpy8n+KxJ7ecXYKcguoNN7taRN6ag=; h=Received:DKIM-Signature:Received:Received:From:To:Cc:Subject: In-Reply-To:References:Date:Message-ID:User-Agent:MIME-Version: Content-Type:X-Pobox-Relay-ID; b=PPP1mGL18Iabijb90lNvgi7BiIUcPfNbS8KTGR1uZWDmzYpk2JHB51BxWKmOBCphmtuPSjP/HOz9OLBYyYO00ORZGVRdwPl/ye2mFJe1aUhWzgddA/+nI+vtGqHZSgY2OFzK35t2uqqtrXG/GgbD/UkjlD7et07qfBHSqLOO6yM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=RNOqGJXa; arc=none smtp.client-ip=64.147.108.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 9FF3F1C4535; Wed, 17 Jan 2024 19:46:22 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=nAYdK49YesM4TJcpy8n+KxJ7ecXYKcguoNN7ta RN6ag=; b=RNOqGJXawFu5w9M8pmBfnp6CbSOVDahvTvH5DpePc+CCmkZ36wcDd5 lzlqITWkE5jHUbx++dA/16rlADZHF6IWi3YJuv3Yz5HPowv2pbsxIpxQCPr2RHG1 aH7uICevHJrPd5LX6/CakN1QGsXGLODuj4SJw5NCmsFaelSGpeZXw= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 973F81C4534; Wed, 17 Jan 2024 19:46:22 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.200.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id A72C01C4531; Wed, 17 Jan 2024 19:46:21 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: "John Cai via GitGitGadget" Cc: git@vger.kernel.org, John Cai Subject: Re: [PATCH 02/12] remove REFFILES prerequisite In-Reply-To: <624ad202305138c312e9db7d9cc590baf4e576ab.1705521155.git.gitgitgadget@gmail.com> (John Cai via GitGitGadget's message of "Wed, 17 Jan 2024 19:52:25 +0000") References: <624ad202305138c312e9db7d9cc590baf4e576ab.1705521155.git.gitgitgadget@gmail.com> Date: Wed, 17 Jan 2024 16:46:20 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: FFD88250-B59A-11EE-A4BE-25B3960A682E-77302942!pb-smtp2.pobox.com "John Cai via GitGitGadget" writes: > From: John Cai > > These tests are compatible with the reftable backend and thus do not > need the REFFILES prerequisite. May want to give a bit more backstory here? After all, 53af25e4 (t1405: mark test that checks existence as REFFILES, 2022-01-31) and 53af25e4 (t1405: mark test that checks existence as REFFILES, 2022-01-31) marked these tests to require REFFILES and they explain the reason for doing so was exactly because the reftable backend did not have the notion of "the reflog for this ref exists" that is independent from "the reflog for this ref exists and has one or more reflog records". If your work on the reftable backend during the past few years added support for "already exists, but there is no entry yet" state for reflogs, that would be great, but it would make sense to explain why they suddenly have become "compatible with the reftable backend". Thanks. > > Signed-off-by: John Cai > --- > t/t1405-main-ref-store.sh | 2 +- > t/t2017-checkout-orphan.sh | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t1405-main-ref-store.sh b/t/t1405-main-ref-store.sh > index e4627cf1b61..62c1eadb190 100755 > --- a/t/t1405-main-ref-store.sh > +++ b/t/t1405-main-ref-store.sh > @@ -112,7 +112,7 @@ test_expect_success 'delete_reflog(HEAD)' ' > test_must_fail git reflog exists HEAD > ' > > -test_expect_success REFFILES 'create-reflog(HEAD)' ' > +test_expect_success 'create-reflog(HEAD)' ' > $RUN create-reflog HEAD && > git reflog exists HEAD > ' > diff --git a/t/t2017-checkout-orphan.sh b/t/t2017-checkout-orphan.sh > index 947d1587ac8..a5c7358eeab 100755 > --- a/t/t2017-checkout-orphan.sh > +++ b/t/t2017-checkout-orphan.sh > @@ -86,7 +86,7 @@ test_expect_success '--orphan makes reflog by default' ' > git rev-parse --verify delta@{0} > ' > > -test_expect_success REFFILES '--orphan does not make reflog when core.logAllRefUpdates = false' ' > +test_expect_success '--orphan does not make reflog when core.logAllRefUpdates = false' ' > git checkout main && > git config core.logAllRefUpdates false && > git checkout --orphan epsilon &&