git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: vk <g@vkabc.me>
Cc: git@vger.kernel.org,  ps@pks.im
Subject: Re: [GSoC] [PATCH] builtin/gc: Replace run_command with C function refs_pack_refs
Date: Wed, 27 Mar 2024 21:31:43 -0700	[thread overview]
Message-ID: <xmqqedbvyo28.fsf@gitster.g> (raw)
In-Reply-To: <0a149be978e68271c251e80f8eb571f4@vkabc.me> (vk's message of "Thu, 28 Mar 2024 12:12:06 +0800")

vk <g@vkabc.me> writes:

> I forgot to add this --auto optional logic. Will add it in the
> following patch.

Please slow down a bit.  If you notice a problem in the patch you
just posted within 7 minutes after posting it, there is a good
chance that you are rushing it without carefully proofreading.

You'd be better off if you give yourself some time to think about
what you wrote, after drafting your patch.  Sleep on it, if needed.

There are issues in the patch.  Trying to spot them yourself would
give you a good exercise.  Documentation/SubmittingPatches and
Documentation/CodingGuidelines would be useful.

Thanks for your interest in Git development.


      reply	other threads:[~2024-03-28  4:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28  4:00 [GSoC] [PATCH] builtin/gc: Replace run_command with C function refs_pack_refs vk
2024-03-28  4:12 ` vk
2024-03-28  4:31   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedbvyo28.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=g@vkabc.me \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).