git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <l.s.r@web.de>, "Git List" <git@vger.kernel.org>,
	"Chandra Pratap" <chandrapratap3519@gmail.com>
Subject: Re: [RFC][PATCH] t-prio-queue: simplify using compound literals
Date: Fri, 05 Apr 2024 15:01:44 -0700	[thread overview]
Message-ID: <xmqqedbjtqnr.fsf@gitster.g> (raw)
In-Reply-To: <20240405191714.GA2561807@coredump.intra.peff.net> (Jeff King's message of "Fri, 5 Apr 2024 15:17:14 -0400")

Jeff King <peff@peff.net> writes:

> Yeah, this seems pretty reasonable. I think we've traditionally been
> hesitant to pass or return structs by value, but that's mostly
> superstition.

We should still be hesitant against the practice to the same degree
that we are hesitant against struct assignment, especially when the
struct is of nontrivial size, or the struct has a pointer member
whose memory ownership semantics goes against shallow copying of the
struct.

In this particular case, I do not know offhand if .strftime_fmt is
safe to be shallowly copied, but I trust you two know and/or have
already looked at the implications.

Thanks.


  reply	other threads:[~2024-04-05 22:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 18:30 [RFC][PATCH] t-prio-queue: simplify using compound literals René Scharfe
2024-04-02 20:31 ` Junio C Hamano
2024-04-02 20:41 ` Jeff King
2024-04-05 17:44   ` René Scharfe
2024-04-05 19:17     ` Jeff King
2024-04-05 22:01       ` Junio C Hamano [this message]
2024-04-06  7:06         ` René Scharfe
2024-04-07  1:28         ` Jeff King
2024-04-08 16:57           ` Junio C Hamano
2024-04-08 17:09             ` Jeff King
2024-04-11 21:23 ` Josh Steadmon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedbjtqnr.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chandrapratap3519@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).