From: Junio C Hamano <gitster@pobox.com>
To: "Niklas Hambüchen" <mail@nh2.me>
Cc: git@vger.kernel.org, petr.mvd@gmail.com
Subject: Re: git format-patch --in-reply-to allows header injection. Intended?
Date: Thu, 04 Sep 2014 16:59:49 -0700 [thread overview]
Message-ID: <xmqqd2bbq6mi.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5408DCC5.8000607@nh2.me> ("Niklas Hambüchen"'s message of "Thu, 04 Sep 2014 23:42:29 +0200")
Niklas Hambüchen <mail@nh2.me> writes:
> On 04/09/14 23:36, Junio C Hamano wrote:
>> While I do not think of a reason to specify such a string to the
>> in-reply-to option (I'd rather edit the output in the editor if I
>> wanted to do anything fancy [*1*]), I do not think there is a reason
>> why you want to add a code to forbid such use, either.
>
> My question was to find out whether I can pass untrusted user input to
> ...
Ah, in general, anybody who passes unvetted user input to any Git
Porcelain deserves what s/he gets, so perhaps you would want to at
least make sure that the input is a single line, or something.
prev parent reply other threads:[~2014-09-04 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 21:21 git format-patch --in-reply-to allows header injection. Intended? Niklas Hambüchen
2014-09-04 21:36 ` Junio C Hamano
2014-09-04 21:42 ` Niklas Hambüchen
2014-09-04 23:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd2bbq6mi.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mail@nh2.me \
--cc=petr.mvd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).