From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Stefan Beller <sbeller@google.com>, git@vger.kernel.org
Subject: Re: [PATCH] wt-status.c: improve readability for wt_shortstatus_print
Date: Thu, 16 Mar 2017 22:25:25 -0700 [thread overview]
Message-ID: <xmqqd1dga30a.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170316225108.GB9135@aiede.mtv.corp.google.com> (Jonathan Nieder's message of "Thu, 16 Mar 2017 15:51:08 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Stefan Beller wrote:
>
>> Subject: wt-status.c: improve readability for wt_shortstatus_print
>
> Maybe:
>
> wt-status: simplify by using for_each_string_list_item
>
> Improve readability by using the for_each_string_list_item helper
> instead of manually iterating with an integer counter.
Much better. That matches what I read from the patch when I skimmed
it, but it did leave me wondering if I missed something else.
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>> wt-status.c | 20 +++++---------------
>> 1 file changed, 5 insertions(+), 15 deletions(-)
>
> I like the diffstat. :)
Me too ;-)
>
> With or without a clarified commit message,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2017-03-17 5:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 21:36 [PATCH] wt-status.c: improve readability for wt_shortstatus_print Stefan Beller
2017-03-16 22:51 ` Jonathan Nieder
2017-03-17 5:25 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd1dga30a.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).