From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 79D9E20960 for ; Fri, 14 Apr 2017 02:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751439AbdDNCC1 (ORCPT ); Thu, 13 Apr 2017 22:02:27 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:54304 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751260AbdDNCCZ (ORCPT ); Thu, 13 Apr 2017 22:02:25 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 2814B89A50; Thu, 13 Apr 2017 22:02:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=xUX4zNRBLHam crsoBwG6M3B8yZk=; b=n7WOz7KnpmvI5IJvUFmj6/1qAyD1UGheMC97mx/9aLZ3 HCw1Av+wE97zAuBSKSJQmtUrMSwpBvjQjdHQ9dvP38ZCoFmWy6ig63id28Vje5OT cHRmy1pjXkPkltTc8YQxQexZ5HP8wlx9lGJGic24m+COpu3kVP62ACO6lOpCrXY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=XkAX2q ncpWyTNZUuGsGsSylhyPJtMo3rynJ4DsofswURPMxhLtTPZQ9cjfG9DhYAxOe3q2 kG0nL8ec6sFUyEKl/qJb8dHYNkGrg34T+6SfU6Maw10UNeg9OwbWxcSYYK91qVMt cgblU8dnGH0d1XP3ApAuIPTj2Dwvv5WpkcOsw= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 1EDB689A4F; Thu, 13 Apr 2017 22:02:24 -0400 (EDT) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 731A489A4E; Thu, 13 Apr 2017 22:02:23 -0400 (EDT) From: Junio C Hamano To: =?utf-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41j?= Duy Cc: git@vger.kernel.org, Michael Haggerty , Stefan Beller Subject: Re: [PATCH v4 0/5] Kill manual ref parsing code in worktree.c References: <20170318100206.5980-1-pclouds@gmail.com> <20170404102123.25315-1-pclouds@gmail.com> Date: Thu, 13 Apr 2017 19:02:22 -0700 In-Reply-To: (Junio C. Hamano's message of "Thu, 13 Apr 2017 18:40:45 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 668EEA10-20B6-11E7-B13C-E680B56B9B0B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > Nguy=E1=BB=85n Th=C3=A1i Ng=E1=BB=8Dc Duy writes: > >> v4 adds a new patch, 2/5, which makes the hashmap related functions in >> refs.c generic, so I could add a new map for worktree ref stores and >> not abuse submodule hashmap. >> >> I mentioned about moving these hashmap back to submodule.c and >> worktree.c where it can map more than just ref stores (in worktree >> case, we can cache 'struct worktree', for example). But I'm not doing >> it now to keep things small. >> >> The commit message in 1/5 is rephrased a bit, hopefully clearer. > > Michael, does this look good to replace what has been queued? > > I did not spot any discussion on this topic after v4 when I skimmed > the backlog messages, so I am hoping that I can pick this up without > having to worry about seeing another reroll immediately after that > (in which case I'd have been better off if I tended other topics in > flight in the meantime). > > Thanks, both. Oops, I shouldn't have done that. When applied on top of the files-backend thing (or have you updated that one and is my tree lacking it???), this breaks quite a few tests. t0001#41 dumps core from "git worktree add ../linked-worktree" for example.