From: Junio C Hamano <gitster@pobox.com>
To: Brandon Williams <bmwill@google.com>
Cc: Stefan Beller <sbeller@google.com>,
Ben Peart <peartben@gmail.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
Jeff King <peff@peff.net>
Subject: Re: [RFC/WIP PATCH] object store classification
Date: Tue, 11 Jul 2017 11:46:03 -0700 [thread overview]
Message-ID: <xmqqd1963j84.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170711180122.GG161700@google.com> (Brandon Williams's message of "Tue, 11 Jul 2017 11:01:22 -0700")
Brandon Williams <bmwill@google.com> writes:
>> the_repository -> the_object_store
>> but the object store is a complex beast having different hash tables
>> for the different alternates.
>
> After looking at the patch and some of the comments here I think that
> this is probably the best approach with a few tweaks (which may be
> completely unfounded because I'm not familiar with all the object store
> code).
>
> In an OO world I would envision a single object (let's say 'struct
> object_store') which is responsible for managing a repository's objects
> no matter where the individual objects came from (main object store or
> an alternate for that repository). And if I understand correctly the
> single hash table that exists now caches objects like this.
I would say that conceptually an object-store object has an
interface to answer "give me info on the object I can refer to with
this object name". At the implementation level, it should have a
hashtable (lazily populated) for all the objects in a single
$GIT_OBJECT_DIRECTORY, grafts/replace info, and a set of pointers to
other object-store instances that are its alternate object stores.
You'd need to have a mechanism to avoid creating cycles in these
pointers, of course.
next prev parent reply other threads:[~2017-07-11 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 20:27 [RFC/WIP PATCH] object store classification Stefan Beller
2017-07-07 2:33 ` Junio C Hamano
2017-07-07 14:56 ` Ben Peart
2017-07-07 16:50 ` Junio C Hamano
2017-07-11 1:17 ` Stefan Beller
2017-07-11 18:01 ` Brandon Williams
2017-07-11 18:46 ` Junio C Hamano [this message]
2017-07-11 19:49 ` Stefan Beller
2017-07-11 20:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd1963j84.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=peartben@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).