From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/15] making user-format colors conditional on config/tty
Date: Thu, 13 Jul 2017 13:46:19 -0700 [thread overview]
Message-ID: <xmqqd194uktg.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170713145553.3epnsw23zajwg3ee@sigill.intra.peff.net> (Jeff King's message of "Thu, 13 Jul 2017 10:55:53 -0400")
Jeff King <peff@peff.net> writes:
> This version also takes into account feedback from the original thread.
> And as I added tests, it surfaced a few corner cases around color config
> that I've dealt with here. The last two patches are the most
> interesting bits.
>
> [01/15]: check return value of verify_ref_format()
> [02/15]: docs/for-each-ref: update pointer to color syntax
> [03/15]: t: use test_decode_color rather than literal ANSI codes
> [04/15]: ref-filter: simplify automatic color reset
> [05/15]: ref-filter: abstract ref format into its own struct
> [06/15]: ref-filter: move need_color_reset_at_eol into ref_format
> [07/15]: ref-filter: provide a function for parsing sort options
> [08/15]: ref-filter: make parse_ref_filter_atom a private function
> [09/15]: ref-filter: factor out the parsing of sorting atoms
> [10/15]: ref-filter: pass ref_format struct to atom parsers
> [11/15]: color: check color.ui in git_default_config()
> [12/15]: for-each-ref: load config earlier
> [13/15]: rev-list: pass diffopt->use_colors through to pretty-print
> [14/15]: pretty: respect color settings for %C placeholders
> [15/15]: ref-filter: consult want_color() before emitting colors
Overall I think the endgame is what we want to have in the future
(rather, what I wish we had from the beginning). I'd have to think
about 11, 14 and 15 a bit more before saying anything that would be
remotely useful.
Thanks.
>
> Documentation/git-for-each-ref.txt | 6 +-
> Documentation/pretty-formats.txt | 18 ++++--
> builtin/branch.c | 21 +++---
> builtin/clean.c | 3 +-
> builtin/for-each-ref.c | 27 ++++----
> builtin/grep.c | 2 +-
> builtin/rev-list.c | 1 +
> builtin/show-branch.c | 2 +-
> builtin/tag.c | 61 ++++++------------
> builtin/verify-tag.c | 14 ++--
> color.c | 8 ---
> config.c | 4 ++
> diff.c | 3 -
> pretty.c | 27 ++++++--
> ref-filter.c | 108 ++++++++++++++++++-------------
> ref-filter.h | 30 +++++++--
> t/t3203-branch-output.sh | 31 +++++++++
> t/t4207-log-decoration-colors.sh | 22 +++----
> t/t6006-rev-list-format.sh | 129 ++++++++++++++++++++++++-------------
> t/t6300-for-each-ref.sh | 39 +++++++----
> t/t7004-tag.sh | 25 +++++++
> t/test-lib-functions.sh | 1 +
> 22 files changed, 362 insertions(+), 220 deletions(-)
>
> -Peff
prev parent reply other threads:[~2017-07-13 20:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 14:55 [PATCH 0/15] making user-format colors conditional on config/tty Jeff King
2017-07-13 14:56 ` [PATCH 01/15] check return value of verify_ref_format() Jeff King
2017-07-13 14:56 ` [PATCH 02/15] docs/for-each-ref: update pointer to color syntax Jeff King
2017-07-13 20:15 ` Junio C Hamano
2017-07-13 14:58 ` [PATCH 03/15] t: use test_decode_color rather than literal ANSI codes Jeff King
2017-07-13 18:40 ` Stefan Beller
2017-07-13 18:45 ` Jeff King
2017-07-13 19:27 ` Junio C Hamano
2017-07-14 11:50 ` Jeff King
2017-07-13 20:18 ` Junio C Hamano
2017-07-13 14:58 ` [PATCH 04/15] ref-filter: simplify automatic color reset Jeff King
2017-07-13 15:01 ` [PATCH 05/15] ref-filter: abstract ref format into its own struct Jeff King
2017-07-13 18:51 ` Stefan Beller
2017-07-13 20:34 ` Junio C Hamano
2017-07-13 21:32 ` Junio C Hamano
2017-07-13 22:01 ` Stefan Beller
2017-07-13 22:45 ` Junio C Hamano
2017-07-13 15:02 ` [PATCH 06/15] ref-filter: move need_color_reset_at_eol into ref_format Jeff King
2017-07-13 20:36 ` Junio C Hamano
2017-07-13 15:02 ` [PATCH 07/15] ref-filter: provide a function for parsing sort options Jeff King
2017-07-13 15:02 ` [PATCH 08/15] ref-filter: make parse_ref_filter_atom a private function Jeff King
2017-07-13 15:02 ` [PATCH 09/15] ref-filter: factor out the parsing of sorting atoms Jeff King
2017-07-13 15:06 ` [PATCH 10/15] ref-filter: pass ref_format struct to atom parsers Jeff King
2017-07-13 15:07 ` [PATCH 11/15] color: check color.ui in git_default_config() Jeff King
2017-07-13 15:07 ` [PATCH 12/15] for-each-ref: load config earlier Jeff King
2017-07-13 15:07 ` [PATCH 13/15] rev-list: pass diffopt->use_colors through to pretty-print Jeff King
2017-07-13 15:08 ` [PATCH 14/15] pretty: respect color settings for %C placeholders Jeff King
2017-07-13 15:09 ` [PATCH 15/15] ref-filter: consult want_color() before emitting colors Jeff King
2017-07-13 19:14 ` [PATCH 0/15] making user-format colors conditional on config/tty Stefan Beller
2017-07-13 20:46 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd194uktg.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).