From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,T_DKIM_INVALID, T_RP_MATCHES_RCVD shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id C7AA91F404 for ; Fri, 2 Mar 2018 21:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932417AbeCBVxh (ORCPT ); Fri, 2 Mar 2018 16:53:37 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:38400 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932131AbeCBVxg (ORCPT ); Fri, 2 Mar 2018 16:53:36 -0500 Received: by mail-wm0-f67.google.com with SMTP id z9so5500775wmb.3 for ; Fri, 02 Mar 2018 13:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=igJMRkU9eEF6RLsqUFSLEmWSGZDCWGkCa/vTxRuvs7k=; b=qBCjNR4Uz8PmPBuWrcOh3TwYzZwgsCC6sAxiXfFEV5DuAOsh6Ze68gdrTUnmkBn0pP CPj++zqT6NpVHwZNlLmjESWCXbB5VEtpUl2alcjZ8B9V4IeS2Cz/Q5ulRkp6EPwRt2Sz ahZtVcpC1iMnmiW39XsN/SuBi4JwstfWUG2pqBV7huv0iG8saT2Fv1MKFJ7Yb8Nx9Rzj xvIyfNzcCT9f8LE6FWJjiwiFrmIQtd09qzHvqmb3Yyj1h/yaSZxjjW+DawT0cGHW7YTf 4UpdXXW182jGSBbmd8jS4hMa7RiJ8tcfs8AFCkfkU6hZGsep5FcGmb2n0h0Qyn8N2z4Z U7Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=igJMRkU9eEF6RLsqUFSLEmWSGZDCWGkCa/vTxRuvs7k=; b=kiWjb1tWz75Ohd4TR2ovZZ4og9OzMJ0SlLJLeeCWpqMr7V/m2ZzbGKj8O02YTKADXa 6y31CpZ8UPwnelnAStRTuHEElWcfqmFCX3Zlxk7fYWAMq8fM04MB2fxa7Yz3d47EiLuU iEXQ12dmCK+OAV1pXgaifqxB2xN0sO1UOGuJuCsEKZn6QjNhHC8hHx6kyHj8l8eyDaJS 9zsTaWyG2l1LUCEIEycmB8XPHx1XUEQ4KYNDR2qq173NhUyz1m0kaMkRrovnTabGDozd alfaorqRP616uy0Sj8XEmfoB6CnmeJ5b9wGzFBgpzlgLsZdPhQwWZxVJkBgnXq0voPWW TJew== X-Gm-Message-State: AElRT7ER1PnzXPlmhFwl6KBfIWonU/qppDL2Mj3tlq03vHNUA0YFFYZI 2NeVVQPY909IL0bhWvR+dc0= X-Google-Smtp-Source: AG47ELt1JNk+QAhybFwX4y6YB3JvZPgeFTt48MPXsifXL7HeZ5tHTW8NgnkdOx0s2x4p0k4Qc06FvA== X-Received: by 10.28.95.139 with SMTP id t133mr2521260wmb.16.1520027614977; Fri, 02 Mar 2018 13:53:34 -0800 (PST) Received: from localhost (168.50.187.35.bc.googleusercontent.com. [35.187.50.168]) by smtp.gmail.com with ESMTPSA id o94sm11335230wrc.7.2018.03.02.13.53.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Mar 2018 13:53:33 -0800 (PST) From: Junio C Hamano To: Sam Kuper Cc: Jeff King , git@vger.kernel.org Subject: Re: Bug report: "Use of uninitialized value $_ in print" References: <20180302104232.GA11074@sigill.intra.peff.net> Date: Fri, 02 Mar 2018 13:53:32 -0800 In-Reply-To: (Sam Kuper's message of "Fri, 2 Mar 2018 20:34:30 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Sam Kuper writes: > 1. It would yield, IIUC, less flexibility to create new kinds of view > based on a consistent, standardised underlying model. > > 2. It is harder to read, for some types of input (e.g. prose) than the > view generated by the existing word-diff algorithm. The loss of line-end by the lossy "word-diff" output does not matter if you never split hunks, but to be able to split a hunk at an in-between context line (which you can already do) and new features like per-line selection that are emerging, keeping 1:1 line correspondence between what is shown and what is applied is a must. Unless you are volunteering to design (notice that I am not saying "implement") both diff generation/coloration side _and_ patch application side, that is. In which case, you may be able to come up with a magic ;-)