From: Junio C Hamano <gitster@pobox.com>
To: Stephon Harris <theonestep4@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] specify encoding for sed command
Date: Mon, 09 Apr 2018 08:17:51 +0900 [thread overview]
Message-ID: <xmqqd0z98ezk.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: 0102016293c8dca7-6626fcde-548d-476e-b61f-c83ecdeedfe1-000000@eu-west-1.amazonses.com
Stephon Harris <theonestep4@gmail.com> writes:
> Fixes issue with seeing `sed: RE error: illegal byte sequence` when running git-completion.bash
> ---
> contrib/completion/git-completion.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index b09c8a23626b4..52a4ab5e2165a 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -282,7 +282,7 @@ __gitcomp ()
>
> # Clear the variables caching builtins' options when (re-)sourcing
> # the completion script.
> -unset $(set |sed -ne 's/^\(__gitcomp_builtin_[a-zA-Z0-9_][a-zA-Z0-9_]*\)=.*/\1/p') 2>/dev/null
> +unset $(set |LANG=C sed -ne 's/^\(__gitcomp_builtin_[a-zA-Z0-9_][a-zA-Z0-9_]*\)=.*/\1/p') 2>/dev/null
Shouldn't LC_ALL and LANG both set and exported to C, as
(1) ancient systems understand only LANG but not LC_*; and
(2) modern ones that understand both give precedence to LC_ALL over
LANG?
If we were to set only one, it is probably more sensible to set
LC_ALL, I suspect, but it may be better to set both, which sends a
sign to the readers that we know what we are doing ;-)
prev parent reply other threads:[~2018-04-08 23:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 3:10 [PATCH] specify encoding for sed command Stephon Harris
2018-04-05 6:53 ` Ævar Arnfjörð Bjarmason
2018-04-05 9:42 ` Eric Sunshine
2018-04-05 9:43 ` SZEDER Gábor
2018-04-10 7:18 ` Matt Coleman
2018-04-11 20:42 ` Matt Coleman
2018-04-12 22:12 ` Matthew Coleman
2018-04-13 0:01 ` SZEDER Gábor
2018-04-13 3:00 ` Matthew Coleman
2018-04-13 10:30 ` [PATCH] completion: reduce overhead of clearing cached --options SZEDER Gábor
2018-04-13 21:44 ` Jakub Narebski
2018-04-13 22:23 ` SZEDER Gábor
2018-04-14 13:27 ` Jakub Narebski
2018-04-16 18:23 ` Jacob Keller
2018-04-16 20:35 ` Matthew Coleman
2018-04-16 5:10 ` Junio C Hamano
2018-04-16 13:15 ` SZEDER Gábor
2018-04-16 13:29 ` Jakub Narębski
2018-04-16 22:43 ` Junio C Hamano
2018-04-17 22:02 ` [PATCH v2] " SZEDER Gábor
2018-04-17 23:45 ` Junio C Hamano
2018-05-07 15:05 ` Matthew Coleman
2018-05-08 2:28 ` Todd Zullinger
2018-05-08 3:28 ` Junio C Hamano
2018-06-07 5:48 ` Jonathan Nieder
2018-06-07 12:07 ` Dave Borowitz
2018-06-07 12:41 ` Rick van Hattem
2018-06-08 21:16 ` SZEDER Gábor
2018-06-08 21:23 ` Jonathan Nieder
2018-06-08 21:41 ` SZEDER Gábor
2018-06-08 21:52 ` Jonathan Nieder
2018-06-08 21:58 ` SZEDER Gábor
2018-06-11 17:53 ` Junio C Hamano
2018-06-11 18:20 ` [PATCH] completion: correct zsh detection when run from git-completion.zsh (Re: [PATCH v2] completion: reduce overhead of clearing cached --options) Jonathan Nieder
2018-06-12 8:46 ` SZEDER Gábor
2018-06-12 9:48 ` SZEDER Gábor
2018-06-12 9:51 ` Rick van Hattem
2018-04-08 23:17 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd0z98ezk.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=theonestep4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).