From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, bmwill@google.com, jrnieder@gmail.com
Subject: Re: [RFC PATCH 0/7] Unset the submodule URL in the superproject when no longer needed
Date: Thu, 16 Aug 2018 08:12:01 -0700 [thread overview]
Message-ID: <xmqqd0uigxby.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180816023100.161626-1-sbeller@google.com> (Stefan Beller's message of "Wed, 15 Aug 2018 19:30:53 -0700")
Stefan Beller <sbeller@google.com> writes:
> Originally we have had the url in the config, (a) that we can change
> the URLs after the "git submodule init" and "git submodule update"
> step that actually clones the submodule if not present and much more
> importantly (b) to know which submodule "was initialized/active".
>
> Now that we have the submodule.active or even
> submodule.<name>.active flags, we do not need (b) any more.
Up to that point the description is sane.
> So the URL turns into a useless piece of cruft that just is unneeded
> and might confuse the user.
>
> Opinions?
You spelled out why you do not need for (b) but not for (a) and
worse it is is unclear if you never need it for (a) or under what
condition you need it for (a). So there isn't enough information to
form an opinion in the above. Sorry--readers need to go to the real
patches.
next prev parent reply other threads:[~2018-08-16 15:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 2:30 [RFC PATCH 0/7] Unset the submodule URL in the superproject when no longer needed Stefan Beller
2018-08-16 2:30 ` [PATCH 1/7] t7410: update to new style Stefan Beller
2018-08-16 17:06 ` Junio C Hamano
2018-08-16 2:30 ` [PATCH 2/7] builtin/submodule--helper: remove stray new line Stefan Beller
2018-08-16 2:30 ` [PATCH 3/7] submodule: is_submodule_active to differentiate between new and old mode Stefan Beller
2018-08-16 17:37 ` Junio C Hamano
2018-08-20 19:50 ` Stefan Beller
2018-08-21 21:39 ` Junio C Hamano
2018-08-16 2:30 ` [PATCH 4/7] submodule sync: omit setting submodule URL in config if possible Stefan Beller
2018-08-16 2:30 ` [PATCH 5/7] submodule--helper: factor out allocation of callback cookie Stefan Beller
2018-08-16 2:30 ` [PATCH 6/7] submodule--helper, update_clone: store index to update_clone instead of ce Stefan Beller
2018-08-16 2:31 ` [PATCH 7/7] builtin/submodule--helper: unset submodule url if possible Stefan Beller
2018-08-16 15:12 ` Junio C Hamano [this message]
2018-08-16 15:45 ` [RFC PATCH 0/7] Unset the submodule URL in the superproject when no longer needed Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd0uigxby.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).