From: Junio C Hamano <gitster@pobox.com>
To: git@jeffhostetler.com
Cc: git@vger.kernel.org, peff@peff.net,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v1 00/25] RFC: structured logging
Date: Tue, 28 Aug 2018 10:38:53 -0700 [thread overview]
Message-ID: <xmqqd0u2gzma.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180713165621.52017-1-git@jeffhostetler.com> (git's message of "Fri, 13 Jul 2018 16:55:56 +0000")
git@jeffhostetler.com writes:
> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> This RFC patch series adds structured logging to git. The motivation,
> ...
>
> Jeff Hostetler (25):
> structured-logging: design document
> structured-logging: add STRUCTURED_LOGGING=1 to Makefile
> structured-logging: add structured logging framework
> structured-logging: add session-id to log events
> structured-logging: set sub_command field for branch command
> structured-logging: set sub_command field for checkout command
> structured-logging: t0420 basic tests
> structured-logging: add detail-event facility
> structured-logging: add detail-event for lazy_init_name_hash
> structured-logging: add timer facility
> structured-logging: add timer around do_read_index
> structured-logging: add timer around do_write_index
> structured-logging: add timer around wt-status functions
> structured-logging: add timer around preload_index
> structured-logging: t0420 tests for timers
> structured-logging: add aux-data facility
> structured-logging: add aux-data for index size
> structured-logging: add aux-data for size of sparse-checkout file
> structured-logging: t0420 tests for aux-data
> structured-logging: add structured logging to remote-curl
> structured-logging: add detail-events for child processes
> structured-logging: add child process classification
> structured-logging: t0420 tests for child process detail events
> structured-logging: t0420 tests for interacitve child_summary
> structured-logging: add config data facility
I noticed that Travis job has been failing with a trivially fixable
failure, so I'll push out today's 'pu' with the attached applied on
top. This may become unapplicable to the code when issues raised in
recent reviews addressed, though.
structured-logging.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/structured-logging.c b/structured-logging.c
index 0e3f79ee48..78abcd2e59 100644
--- a/structured-logging.c
+++ b/structured-logging.c
@@ -593,8 +593,7 @@ void slog_set_command_name(const char *command_name)
* the cmd_<command>() and/or it may be too early to force a
* lazy load.
*/
- if (my__command_name)
- free(my__command_name);
+ free(my__command_name);
my__command_name = xstrdup(command_name);
}
@@ -606,8 +605,7 @@ void slog_set_sub_command_name(const char *sub_command_name)
* the cmd_<command>() and/or it may be too early to force a
* lazy load.
*/
- if (my__sub_command_name)
- free(my__sub_command_name);
+ free(my__sub_command_name);
my__sub_command_name = xstrdup(sub_command_name);
}
--
2.19.0-rc0-48-gb9dfa238d5
next prev parent reply other threads:[~2018-08-28 17:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 16:55 [PATCH v1 00/25] RFC: structured logging git
2018-07-13 16:55 ` [PATCH v1 01/25] structured-logging: design document git
2018-07-14 8:34 ` Simon Ruderich
2018-08-03 15:26 ` Ben Peart
2018-08-09 14:30 ` Jeff Hostetler
2018-08-21 4:47 ` Jonathan Nieder
2018-07-13 16:55 ` [PATCH v1 02/25] structured-logging: add STRUCTURED_LOGGING=1 to Makefile git
2018-08-21 4:49 ` Jonathan Nieder
2018-07-13 16:55 ` [PATCH v1 03/25] structured-logging: add structured logging framework git
2018-07-26 9:09 ` SZEDER Gábor
2018-07-27 12:45 ` Jeff Hostetler
2018-08-21 5:05 ` Jonathan Nieder
2018-07-13 16:56 ` [PATCH v1 04/25] structured-logging: add session-id to log events git
2018-07-13 16:56 ` [PATCH v1 05/25] structured-logging: set sub_command field for branch command git
2018-07-13 16:56 ` [PATCH v1 06/25] structured-logging: set sub_command field for checkout command git
2018-07-13 16:56 ` [PATCH v1 07/25] structured-logging: t0420 basic tests git
2018-07-13 16:56 ` [PATCH v1 08/25] structured-logging: add detail-event facility git
2018-07-13 16:56 ` [PATCH v1 09/25] structured-logging: add detail-event for lazy_init_name_hash git
2018-07-13 16:56 ` [PATCH v1 10/25] structured-logging: add timer facility git
2018-07-13 16:56 ` [PATCH v1 11/25] structured-logging: add timer around do_read_index git
2018-07-13 16:56 ` [PATCH v1 12/25] structured-logging: add timer around do_write_index git
2018-07-13 16:56 ` [PATCH v1 13/25] structured-logging: add timer around wt-status functions git
2018-07-13 16:56 ` [PATCH v1 14/25] structured-logging: add timer around preload_index git
2018-07-13 16:56 ` [PATCH v1 15/25] structured-logging: t0420 tests for timers git
2018-07-13 16:56 ` [PATCH v1 16/25] structured-logging: add aux-data facility git
2018-07-13 16:56 ` [PATCH v1 17/25] structured-logging: add aux-data for index size git
2018-07-13 16:56 ` [PATCH v1 18/25] structured-logging: add aux-data for size of sparse-checkout file git
2018-07-13 16:56 ` [PATCH v1 19/25] structured-logging: t0420 tests for aux-data git
2018-07-13 16:56 ` [PATCH v1 20/25] structured-logging: add structured logging to remote-curl git
2018-07-13 16:56 ` [PATCH v1 21/25] structured-logging: add detail-events for child processes git
2018-07-13 16:56 ` [PATCH v1 22/25] structured-logging: add child process classification git
2018-07-13 16:56 ` [PATCH v1 23/25] structured-logging: t0420 tests for child process detail events git
2018-07-13 16:56 ` [PATCH v1 24/25] structured-logging: t0420 tests for interacitve child_summary git
2018-07-13 16:56 ` [PATCH v1 25/25] structured-logging: add config data facility git
2018-07-13 18:51 ` [PATCH v1 00/25] RFC: structured logging David Lang
2018-07-16 13:29 ` Jeff Hostetler
2018-08-28 17:38 ` Junio C Hamano [this message]
2018-08-28 18:47 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd0u2gzma.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).