mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Jonathan Nieder <>
Cc: Jonathan Tan <>,
Subject: Re: [PATCH] fetch-pack: send server options after command
Date: Tue, 28 May 2019 11:00:22 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Jonathan Nieder's message of "Fri, 24 May 2019 12:11:51 -0700")

Jonathan Nieder <> writes:

> Jonathan Tan wrote:
>> Currently, if any server options are specified during a protocol v2
>> fetch, server options will be sent before "command=fetch". Write server
>> options to the request buffer in send_fetch_request() so that the
>> components of the request are sent in the correct order.
>> The protocol documentation states that the command must come first. The
>> Git server implementation in serve.c (see process_request() in that
>> file) tolerates any order of command and capability, which is perhaps
>> why we haven't noticed this. This was noticed when testing against a
>> JGit server implementation, which follows the documentation in this
>> regard.
>> Signed-off-by: Jonathan Tan <>
>> ---
>>  fetch-pack.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> Oh, dear.  Thanks for fixing it.
> Reviewed-by: Jonathan Nieder <>

Yeah, looks good.  Thanks.

> 6e98305985 (clone: send server options when using protocol v2,
> 2019-04-12) is part of release candidates, but it looks like we caught
> this in time to get the fix in before the release.
> Should we add an interop test for this to t/interop/?
> Thanks,
> Jonathan

      reply	other threads:[~2019-05-28 18:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 20:08 [PATCH] fetch-pack: send server options after command Jonathan Tan
2019-05-24 19:11 ` Jonathan Nieder
2019-05-28 18:00   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).