git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Bryan Turner <bturner@atlassian.com>,
	Takuya N via GitGitGadget <gitgitgadget@gmail.com>,
	Git Users <git@vger.kernel.org>,
	Takuya Noguchi <takninnovationresearch@gmail.com>
Subject: Re: [PATCH] doc: use 'ref' instead of 'commit' for merge-base arguments
Date: Tue, 03 Mar 2020 06:30:44 -0800	[thread overview]
Message-ID: <xmqqd09ta4tn.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2003031507500.46@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Tue, 3 Mar 2020 15:08:08 +0100 (CET)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> > The notation <commit> can be misunderstandable only for commit SHA1,
>> > but merge-base accepts any commit references. Like reflog, the name of
>> > arguments should be <ref> instead of <commit>.
>>
>> To me, this change goes too far in the opposite direction: Now it
>> sounds like the command only accepts refs, when it actually accepts
>> any "commit-ish"--i.e., anything that can be coerced to a commit.
>> ("git worktree" uses this term in its usage for "add", for example.)
>
> Maybe we can go for `rev` instead of `ref`?

That's much better than 'ref', but I do not see why 'commit' is
wrong in the first place.  There are many ways to name an object,
and `rev` is an old colloquial way to say "object name".  Here,
however, we want only commit objects, no?

  reply	other threads:[~2020-03-03 14:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03  7:23 [PATCH] doc: use 'ref' instead of 'commit' for merge-base arguments Takuya N via GitGitGadget
2020-03-03  7:32 ` Bryan Turner
2020-03-03 14:08   ` Johannes Schindelin
2020-03-03 14:30     ` Junio C Hamano [this message]
2020-03-03 19:38       ` Johannes Schindelin
2020-03-03 20:08         ` Junio C Hamano
2020-03-04 12:38 ` [PATCH v2] doc: use 'rev' " Takuya N via GitGitGadget
2020-03-04 16:44   ` Junio C Hamano
2020-03-04 17:26     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqd09ta4tn.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bturner@atlassian.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=takninnovationresearch@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).