git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] t1509: correct i18n test
Date: Wed, 13 May 2020 09:43:11 -0700	[thread overview]
Message-ID: <xmqqd077vl9c.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <6675cb952771a48a50b46bcf577e363fcf5d7b3b.1589375923.git.congdanhqx@gmail.com> ("Đoàn Trần Công Danh"'s message of "Wed, 13 May 2020 20:23:06 +0700")

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

> git-init(1)'s messages is subjected to i18n.
> They should be tested by test_i18n* family.
>
> Fix them.
>
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> ---
>  t/t1509-root-work-tree.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t1509-root-work-tree.sh b/t/t1509-root-work-tree.sh
> index 553a3f601b..fd2f7abf1c 100755
> --- a/t/t1509-root-work-tree.sh
> +++ b/t/t1509-root-work-tree.sh
> @@ -221,7 +221,7 @@ test_expect_success 'setup' '
>  	rm -rf /.git &&
>  	echo "Initialized empty Git repository in /.git/" > expected &&
>  	git init > result &&
> -	test_cmp expected result
> +	test_i18ncmp expected result
>  '
>  
>  test_vars 'auto gitdir, root' ".git" "/" ""
> @@ -246,7 +246,7 @@ test_expect_success 'setup' '
>  	cd / &&
>  	echo "Initialized empty Git repository in /" > expected &&
>  	git init --bare > result &&
> -	test_cmp expected result
> +	test_i18ncmp expected result
>  '
>  
>  test_vars 'auto gitdir, root' "." "" ""

OK.  It shows how rarely (if ever) this test script is actually
exercised that we need fixes like these.  Well done.

Thanks.

  reply	other threads:[~2020-05-13 16:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 13:23 [PATCH 0/2] CI: Enable t1509 on GitHub Actions and Travis Đoàn Trần Công Danh
2020-05-13 13:23 ` [PATCH 1/2] t1509: correct i18n test Đoàn Trần Công Danh
2020-05-13 16:43   ` Junio C Hamano [this message]
2020-05-13 13:23 ` [PATCH 2/2] CI: enable t1509 in Travis and GitHub Actions Đoàn Trần Công Danh
2020-05-13 16:51   ` Junio C Hamano
2020-05-13 23:52     ` Đoàn Trần Công Danh
2020-05-13 23:59       ` Junio C Hamano
2020-05-13 16:41 ` [PATCH 0/2] CI: Enable t1509 on GitHub Actions and Travis Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqd077vl9c.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=congdanhqx@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).