From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"Marco Trevisan via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Marco Trevisan" <mail@3v1n0.net>
Subject: Re: [PATCH] completion: use native ZSH array pattern matching
Date: Thu, 28 May 2020 08:54:49 -0700 [thread overview]
Message-ID: <xmqqd06o3vhy.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200528021727.GH1915090@camp.crustytoothpaste.net> (brian m. carlson's message of "Thu, 28 May 2020 02:17:27 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> On 2020-05-27 at 06:13:59, Carlo Marcelo Arenas Belón wrote:
>> On Tue, May 26, 2020 at 11:58:34PM +0000, brian m. carlson wrote:
>> >
>> > This file is necessarily used by both bash and zsh. Does bash
>> > (including the bash 3 used on macOS) happen to continue to work with
>> > this syntax?
>>
>> if by that you meant t9902.[150-152] to succeed with macOS bash?:
>>
>> $ bash --version
>> GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin17)
>> Copyright (C) 2007 Free Software Foundation, Inc.
>>
>> then I think we can add (on top of master):
>>
>> Tested-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
>
> Yes, that is what I meant. I'm glad to know my question has been
> answered and things work. I'm okay with the patch as it is in that
> case, although I'd give bonus points for mentioning that this syntax
> doesn't regress bash.
True. And we would want to also have tested-by on more recent
versions of bash, no?
next prev parent reply other threads:[~2020-05-28 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 19:13 [PATCH] completion: use native ZSH array pattern matching Marco Trevisan via GitGitGadget
2020-05-26 23:58 ` brian m. carlson
2020-05-27 6:13 ` Carlo Marcelo Arenas Belón
2020-05-28 2:17 ` brian m. carlson
2020-05-28 15:54 ` Junio C Hamano [this message]
2020-05-28 22:57 ` brian m. carlson
2020-05-28 23:01 ` Junio C Hamano
2020-05-28 16:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd06o3vhy.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=mail@3v1n0.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).