From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <l.s.r@web.de>, "Taylor Blau" <me@ttaylorr.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] fast-export: factor out print_oid()
Date: Mon, 17 Aug 2020 15:53:21 -0700 [thread overview]
Message-ID: <xmqqd03ozxy6.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200817220843.GA1858228@coredump.intra.peff.net> (Jeff King's message of "Mon, 17 Aug 2020 18:08:43 -0400")
Jeff King <peff@peff.net> writes:
> On Sat, Aug 15, 2020 at 09:14:49AM +0200, René Scharfe wrote:
>
>> > I think this is a bad direction unless you're going to do it for all of
>> > the other anonymize_*() functions, as well, for consistency. And there
>> > it gets tricky because the caller is able to use the anonymizing
>> > knowledge in more places.
>> >
>> > I actually liked your original version better.
>>
>> OK, how about embracing the static and do something like this?
>>
>> -- >8 --
>> Subject: [PATCH] fast-export: add format_oid() and format_path()
>
> TBH, I don't find it an improvement because of the extra buffer
> handling. But I admit that I don't really care between any of the
> solutions posted here. They all appear to be correct, and just trading
> off various properties so that none is definitively better than the
> other. (And none of them is so bad that I feel compelled to avoid it).
>
> So I'd be OK with any of them (or leaving it as-is).
>
> -Peff
I've marked it as "retracted" per
https://lore.kernel.org/git/6e2d4472-8293-4f10-0ba6-82ae83f7a465@web.de/
Thanks.
next prev parent reply other threads:[~2020-08-17 22:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 11:11 [PATCH] fast-export: factor out print_oid() René Scharfe
2020-08-13 11:58 ` Jeff King
2020-08-13 17:17 ` René Scharfe
2020-08-13 15:18 ` Taylor Blau
2020-08-13 17:17 ` René Scharfe
2020-08-13 17:25 ` Jeff King
2020-08-15 7:14 ` René Scharfe
2020-08-17 22:08 ` Jeff King
2020-08-17 22:53 ` Junio C Hamano [this message]
2020-08-13 18:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd03ozxy6.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).