From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 730C51F4B4 for ; Thu, 17 Sep 2020 00:59:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726170AbgIQA7i (ORCPT ); Wed, 16 Sep 2020 20:59:38 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:63248 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbgIQA7d (ORCPT ); Wed, 16 Sep 2020 20:59:33 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 6389EEA534; Wed, 16 Sep 2020 20:59:30 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=2ugJzRVX5S2N+QY9sIx6dAsbnfw=; b=eNw/Ud Fv99X6LdfbJiNfbSM/pzE+SGNdrI1YDNf2yk5ryc23umGsBVIBrPNKodvPGEMsVT q2b+yglYfkWE2Zclt7SPb5G9QNqCDcbu1TKTmMEm5DddOojXtphpPP7FMQh9bKc+ 8WxdBnJ1omJ59xtbvfPNqEvAlgKgJMvxm7Xqw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; q=dns; s=sasl; b=d0zED4ELkZEeLlhSVpxASdgY9t1Fe+2M CMPVxvqBn/1Ix27EZuOD4jnN2/bX/Fh/B3f/3a+Pic5xyxORbZZ4YnGxONd2/RBU PIf0V4HP4GLgZMlzY7L5c2ApnDItYaxwtiWtexEfdQWEZp8ExRYlTtHPdXt6QN1L FWfVQF+3NR4= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 5B9F1EA533; Wed, 16 Sep 2020 20:59:30 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id A6961EA532; Wed, 16 Sep 2020 20:59:27 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Taylor Blau Cc: Derrick Stolee , git@vger.kernel.org, dstolee@microsoft.com, peff@peff.net, szeder.dev@gmail.com Subject: Re: [PATCH v2 00/13] more miscellaneous Bloom filter improvements, redux In-Reply-To: <20200917004518.GA6478@nand.local> (Taylor Blau's message of "Wed, 16 Sep 2020 20:45:18 -0400") References: <20200917004518.GA6478@nand.local> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Date: Wed, 16 Sep 2020 17:59:26 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 093263E6-F881-11EA-B1DB-F0EA2EB3C613-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Taylor Blau writes: > On Wed, Sep 16, 2020 at 04:07:51PM -0700, Junio C Hamano wrote: >> Yup, lets merge it down soonish. > > It's me, the bearer of bad news. I noticed an uninitialized read when > running the tests with SANITIZE=address,undefined. I *think* the fix is > as simple as a single replacement, but let me double check before you > merge this. > > Sorry this topic has been such a disaster. Assuming the fix is isolated > to a single patch, do you want a new version of that patch, or the whole > series? Depends on the timing---if it takes less than 2 days, please expect that the topic would still be in my cache and "squash this into patch 07/13" would be sufficient. More than 10 days, wholesale replacement would be the easiest. A single patch replacement in between. Thanks.