From: Junio C Hamano <email@example.com> To: Taylor Blau <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org Subject: Re: [PATCH 3/3] builtin/repack.c: don't move existing packs out of the way Date: Mon, 16 Nov 2020 16:46:06 -0800 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <X7MYifflg7SaTRXm@nand.local> (Taylor Blau's message of "Mon, 16 Nov 2020 19:25:45 -0500") Taylor Blau <firstname.lastname@example.org> writes: >> In any case, much of what I speculated while reading the proposed >> log message turned out to be false, which may be a sign that the log >> message did not explain the approach clearly enough. I thought that >> a newly created file that happened to be identical to existing ones >> would be discarded without getting renamed to their final location, >> but the code does not do such special casing. I thought the >> 'metadata' it talks about were to compensate for side effects of >> reusing the old files, but that was not what the 'metadata' was even >> about. > > It's more about: ... You do not have to explain that to me here. Instead explain that to future readers of our history in the commit log message. Thanks.
next prev parent reply other threads:[~2020-11-17 0:47 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-16 18:41 [PATCH 0/3] repack: " Taylor Blau 2020-11-16 18:41 ` [PATCH 1/3] repack: make "exts" array available outside cmd_repack() Taylor Blau 2020-11-16 18:41 ` [PATCH 2/3] builtin/repack.c: keep track of what pack-objects wrote Taylor Blau 2020-11-16 18:41 ` [PATCH 3/3] builtin/repack.c: don't move existing packs out of the way Taylor Blau 2020-11-16 23:29 ` Junio C Hamano 2020-11-17 0:02 ` Jeff King 2020-11-17 0:26 ` Taylor Blau 2020-11-17 0:25 ` Taylor Blau 2020-11-17 0:46 ` Junio C Hamano [this message] 2020-11-17 20:15 ` Taylor Blau 2020-11-17 21:28 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 3/3] builtin/repack.c: don'\''t move existing packs out of the way' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).