From: Junio C Hamano <gitster@pobox.com>
To: Aaron Hall <aaronchallmba@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Default ssh command
Date: Tue, 06 Jul 2021 18:48:09 -0700 [thread overview]
Message-ID: <xmqqczrugahy.fsf@gitster.g> (raw)
In-Reply-To: <CADrEZfE+LuDnhWkRHPMwHq7aGYcvDeqken8uZzPgHREtf0iqjA@mail.gmail.com> (Aaron Hall's message of "Tue, 6 Jul 2021 21:35:30 -0400")
Aaron Hall <aaronchallmba@gmail.com> writes:
> I was trying to push some binary files (PNGs) over ssh and found some
> files inexplicably wouldn't successfully push.
>
> I set, in my .gitconfig file:
>
> [core]
> sshCommand = ssh -e none
>
> And it works now for all files (that I can tell).
>
> From a close examination of the output where I noted escape codes
> showing up, I believe the problem to be ssh escape codes.
>
> `\n~.` for example closes the ssh client.
>
> Therefore I think the default ssh command should be `ssh -e none`
> instead of `ssh` for the benefit of users who won't recognize the
> problem, unless `git` is expected to make use of ssh escape codes.
Curious.
When we use ssh to run the receive-pack over the wire while pushing,
we do not ask for pty, and because the "-e" option to set the escape
character is meaningful only when ssh runs with pty allocated, you
shouldn't have to do this, unless you force pty allocation by
e.g. passing "-t" yourself.
next prev parent reply other threads:[~2021-07-07 1:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 1:35 Default ssh command Aaron Hall
2021-07-07 1:48 ` Junio C Hamano [this message]
[not found] ` <CADrEZfGHAi=Lr6QMsJbXGy1Rs9VDzTVxQPNH4xHHj6ataEAvVA@mail.gmail.com>
[not found] ` <CADrEZfHJZT47nNZJ8v2T4vOJkMN7ccaai6DKdzFLF8Zoc42hWw@mail.gmail.com>
2021-07-07 2:13 ` Aaron Hall
2021-07-07 13:29 ` brian m. carlson
2021-07-08 13:50 ` Aaron Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczrugahy.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aaronchallmba@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).