From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 9D3A61F953 for ; Wed, 27 Oct 2021 20:03:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240474AbhJ0UGK (ORCPT ); Wed, 27 Oct 2021 16:06:10 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:54901 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234274AbhJ0UGJ (ORCPT ); Wed, 27 Oct 2021 16:06:09 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id B056715A318; Wed, 27 Oct 2021 16:03:43 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=p4WnsIalBO+C8pMXvReoAPsXUxS8C8Vyx98wwH +X9L8=; b=S6HdYG3UKhw9c+HYFamVXZTZJF4xYXKYvFUKxnE3Xu7ljx9KWNly1V KplSIkC2Yb66oNIrGv6rceOPAkbueapGeKz0FLjcog29P76+WYyWXN6bH3GKLMq8 mSkvseI3yjGOGdOApnooPFEX0KUDBoAoSpVu6Ux+j+ibEQBM9b08I= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id A8CA015A317; Wed, 27 Oct 2021 16:03:43 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 1300615A315; Wed, 27 Oct 2021 16:03:41 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Glen Choo Cc: git@vger.kernel.org Subject: Re: [PATCH v3 2/4] remote: use remote_state parameter internally References: Date: Wed, 27 Oct 2021 13:03:39 -0700 In-Reply-To: (Glen Choo's message of "Wed, 27 Oct 2021 10:59:22 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: FB1BAD1A-3760-11EC-B677-F327CE9DA9D6-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Glen Choo writes: > I might not want to take action on these ideas though, e.g. > branch_get("HEAD") or remote_for_branch(NULL) are very convenient > for callers even though they behave slightly inconsisently. I'll > propose a longer term direction when I have a better grasp of the > system and the tradeoffs. Yup, that sounds like a good plan.