git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
* "format-patch" command doesn't support SSH signing
@ 2021-11-23 13:04 Marcos Alano
  2021-11-23 16:02 ` Ævar Arnfjörð Bjarmason
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Marcos Alano @ 2021-11-23 13:04 UTC (permalink / raw)
  To: git

Hello,

I was trying to generate a patch to send to a project (Linux 
specifically) but when I generate the patch using "format-patch" I saw 
there was no "Signed-Off" line, but my commit is signed using SSH. My 
git version is the latest, 2.34.

Thank you.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: "format-patch" command doesn't support SSH signing
  2021-11-23 13:04 "format-patch" command doesn't support SSH signing Marcos Alano
@ 2021-11-23 16:02 ` Ævar Arnfjörð Bjarmason
  2021-11-23 16:14 ` Johannes Schindelin
  2021-11-24  0:49 ` Junio C Hamano
  2 siblings, 0 replies; 4+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2021-11-23 16:02 UTC (permalink / raw)
  To: Marcos Alano; +Cc: git


On Tue, Nov 23 2021, Marcos Alano wrote:

> Hello,
>
> I was trying to generate a patch to send to a project (Linux
> specifically) but when I generate the patch using "format-patch" I saw 
> there was no "Signed-Off" line, but my commit is signed using SSH. My
> git version is the latest, 2.34.

The Signed-off-by in commit messages doesn't have anything to do with
SSH, GPG etc. signing, it's just a way of signaling that you're the
author of the change, and/or can certify it as being includable in the
project for authorship & copyright reasons. It's mostly used in
linux.git and git.git, see a "git grep Signed-off-by" in those for more
details.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: "format-patch" command doesn't support SSH signing
  2021-11-23 13:04 "format-patch" command doesn't support SSH signing Marcos Alano
  2021-11-23 16:02 ` Ævar Arnfjörð Bjarmason
@ 2021-11-23 16:14 ` Johannes Schindelin
  2021-11-24  0:49 ` Junio C Hamano
  2 siblings, 0 replies; 4+ messages in thread
From: Johannes Schindelin @ 2021-11-23 16:14 UTC (permalink / raw)
  To: Marcos Alano; +Cc: git

Hi Marcos,

On Tue, 23 Nov 2021, Marcos Alano wrote:

> I was trying to generate a patch to send to a project (Linux specifically) but
> when I generate the patch using "format-patch" I saw there was no "Signed-Off"
> line, but my commit is signed using SSH. My git version is the latest, 2.34.

A "Sign-off" is a convention for the commit message, but _signing a
commit_ is a cryptographic signature. They are two different things.

You can add the "Signed-off-by:" trailers via `git format-patch`'s
`--signoff` option:
https://git-scm.com/docs/git-format-patch#Documentation/git-format-patch.txt---signoff

Ciao,
Johannes

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: "format-patch" command doesn't support SSH signing
  2021-11-23 13:04 "format-patch" command doesn't support SSH signing Marcos Alano
  2021-11-23 16:02 ` Ævar Arnfjörð Bjarmason
  2021-11-23 16:14 ` Johannes Schindelin
@ 2021-11-24  0:49 ` Junio C Hamano
  2 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2021-11-24  0:49 UTC (permalink / raw)
  To: Marcos Alano; +Cc: git

Marcos Alano <marcoshalano@gmail.com> writes:

> I was trying to generate a patch to send to a project (Linux
> specifically) but when I generate the patch using "format-patch" I saw 
> there was no "Signed-Off" line, but my commit is signed using SSH. My
> git version is the latest, 2.34.

Sign-off in Linux kernel project is to certify that you have the
right to contribute the change to the project under Developers
certificate of origin.  I believe in thier project, the document
in Documentation/process/submitting-patches.rst describes the
process (look for "Sign your work")

The "commit -s" signing has nothing to do with it.  It may prove it
was written by the key holder, but it does not prevent the key
holder to steal intellectual property from their employer and
contribute it as if it is their own, and Sign-off exists as a
separate procedure to have you raise your right hand and swear that
your contribution is kosher wrt DCO.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-24  0:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 13:04 "format-patch" command doesn't support SSH signing Marcos Alano
2021-11-23 16:02 ` Ævar Arnfjörð Bjarmason
2021-11-23 16:14 ` Johannes Schindelin
2021-11-24  0:49 ` Junio C Hamano

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).